[pbs-devel] [PATCH proxmox] fix #4162: sys: added `auto-submitted` header to email body

[pbs-devel] [PATCH proxmox] fix #4162: sys: added `auto-submitted` header to email body

[Gabriel Goller]

`Auto-Submitted` is defined in the rfc 5436 [1] and describes how
an automatic response (f.e. ooo replies, etc.) should behave on the
emails. When using `Auto-Submitted: auto-generated` (or any value
other than `none`) automatic replies won't be triggered.

[1]: https://www.rfc-editor.org/rfc/rfc3834.html

Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---
 proxmox-sys/src/email.rs | 1 +
 1 file changed, 1 insertion(+)

diff --git a/proxmox-sys/src/email.rs b/proxmox-sys/src/email.rs
index da910d4..9f53718 100644
--- a/proxmox-sys/src/email.rs
+++ b/proxmox-sys/src/email.rs
@@ -81,6 +81,7 @@ pub fn sendmail(
     }
     if let Some(html) = html {
         body.push_str("Content-Type: text/html;\n");
+        body.push_str("Auto-Submitted: auto-generated;\n");
         body.push_str("\tcharset=\"UTF-8\"\n");
         body.push_str("Content-Transfer-Encoding: 8bit\n");
         body.push('\n');
-- 
2.39.2

Re: [pbs-devel] [PATCH proxmox] fix #4162: sys: added `auto-submitted` header to email body

[Thomas Lamprecht]

On 28/08/2023 10:44, Gabriel Goller wrote:
> `Auto-Submitted` is defined in the rfc 5436 [1] and describes how
> an automatic response (f.e. ooo replies, etc.) should behave on the
> emails. When using `Auto-Submitted: auto-generated` (or any value
> other than `none`) automatic replies won't be triggered.
> 
> [1]: https://www.rfc-editor.org/rfc/rfc3834.html
> 
> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> ---
>  proxmox-sys/src/email.rs | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/proxmox-sys/src/email.rs b/proxmox-sys/src/email.rs
> index da910d4..9f53718 100644
> --- a/proxmox-sys/src/email.rs
> +++ b/proxmox-sys/src/email.rs
> @@ -81,6 +81,7 @@ pub fn sendmail(

Please add the fact that this is always for auto-generated mails to the
doc comment, so that anybody that wants to use this for something where
a human actually writes/sends the mail is aware of this behavior.

>      }
>      if let Some(html) = html {

why only add this to mails that include HTML, but not pure plain text ones?
Didn't see anything in the RFC that would indicate it should be done this
way, or did I overlook that part? 

>          body.push_str("Content-Type: text/html;\n");
> +        body.push_str("Auto-Submitted: auto-generated;\n");
>          body.push_str("\tcharset=\"UTF-8\"\n");
>          body.push_str("Content-Transfer-Encoding: 8bit\n");
>          body.push('\n');

Re: [pbs-devel] [PATCH proxmox] fix #4162: sys: added `auto-submitted` header to email body

[Gabriel Goller]

Sent a new patch version.

On 9/7/23 17:42, Thomas Lamprecht wrote:
> On 28/08/2023 10:44, Gabriel Goller wrote:
>> `Auto-Submitted` is defined in the rfc 5436 [1] and describes how
>> an automatic response (f.e. ooo replies, etc.) should behave on the
>> emails. When using `Auto-Submitted: auto-generated` (or any value
>> other than `none`) automatic replies won't be triggered.
>>
>> [1]: https://www.rfc-editor.org/rfc/rfc3834.html
>>
>> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
>> ---
>>   proxmox-sys/src/email.rs | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/proxmox-sys/src/email.rs b/proxmox-sys/src/email.rs
>> index da910d4..9f53718 100644
>> --- a/proxmox-sys/src/email.rs
>> +++ b/proxmox-sys/src/email.rs
>> @@ -81,6 +81,7 @@ pub fn sendmail(
> Please add the fact that this is always for auto-generated mails to the
> doc comment, so that anybody that wants to use this for something where
> a human actually writes/sends the mail is aware of this behavior.
>
>>       }
>>       if let Some(html) = html {
> why only add this to mails that include HTML, but not pure plain text ones?
> Didn't see anything in the RFC that would indicate it should be done this
> way, or did I overlook that part?
>
>>           body.push_str("Content-Type: text/html;\n");
>> +        body.push_str("Auto-Submitted: auto-generated;\n");
>>           body.push_str("\tcharset=\"UTF-8\"\n");
>>           body.push_str("Content-Transfer-Encoding: 8bit\n");
>>           body.push('\n');