From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>, Markus Frank <m.frank@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup v3] api: enhance directory existence check
Date: Mon, 8 Apr 2024 15:13:57 +0200 [thread overview]
Message-ID: <617bfb47-88a5-410d-97e9-54a265397167@proxmox.com> (raw)
In-Reply-To: <20231130103724.46301-1-m.frank@proxmox.com>
The commit subject is not really telling, "enhance" can mean lots of things
and which directory check is meant would be also good to get here...
I changed it to:
"api: datastore create: allow re-using existing dirs if empty & not a mountpoint"
It's a bit crowded, but much more telling about what this is about.
I also reworded the commit message, as when reading first I got slightly
confused and for a moment thought that we allowed this before your patch, but
would not allow it anymore now.
Am 30/11/2023 um 11:37 schrieb Markus Frank:
> If a directory exists on the specified path,
> it now also checks whether the directory is empty and not already mounted.
>
> Previously, if a directory were deleted and a directory with the same name
> would be created, the old check prevented the creation even though the
> directory could be used as a mount point.
>
> Signed-off-by: Markus Frank <m.frank@proxmox.com>
> Tested-by: Christian Ebner <c.ebner@proxmox.com>
> ---
> v3: changed comment
> v2: added check if another file system is mounted on the specified path
>
> src/api2/node/disks/directory.rs | 15 ++++++++++++---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2024-04-08 13:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 10:37 [pbs-devel] " Markus Frank
2024-04-08 12:27 ` Markus Frank
2024-04-08 13:13 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=617bfb47-88a5-410d-97e9-54a265397167@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=m.frank@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox