From: Mira Limbeck <m.limbeck@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 2/2] fix #4977: ui: tape: restore: rework snapshot selection logic
Date: Mon, 2 Oct 2023 11:14:37 +0200 [thread overview]
Message-ID: <60e51b2c-b3cb-0a68-3aa9-918aa350935e@proxmox.com> (raw)
In-Reply-To: <af0292b4-5f53-4f95-a94a-b9eb64568016@proxmox.com>
On 10/2/23 08:47, Dominik Csapak wrote:
> On 9/29/23 17:30, Mira Limbeck wrote:
>> I've tested it here and ran into an issue.
>> When you select a target namespace for one datastore, and none for the
>> other, the snapshots that are mapped to the root namespace won't be
>> restored, with the following warning:
>>
>>
>> 2023-09-29T17:25:23+02:00: WARN: could not find target namespace for
>> test:vm/100/2023-01-24T10:47:49Z
>>
>
> thanks for the review!
>
> while that behaviour is unexpected (and i'll see to it that i fix it in the
> gui) it's not really related to this fix and it behaved like that before
> too.
>
Since the original issue was fixed by the patch and I couldn't find any
issue other than the reported one for which you sent a fix already,
consider this patch:
Tested-by: Mira Limbeck <m.limbeck@proxmox.com>
next prev parent reply other threads:[~2023-10-02 9:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 13:39 [pbs-devel] [PATCH proxmox-backup 1/2] ui: tape: restore: improve variable names Dominik Csapak
2023-09-29 13:39 ` [pbs-devel] [PATCH proxmox-backup 2/2] fix #4977: ui: tape: restore: rework snapshot selection logic Dominik Csapak
2023-09-29 15:30 ` Mira Limbeck
2023-10-02 6:47 ` Dominik Csapak
2023-10-02 9:14 ` Mira Limbeck [this message]
2023-11-09 7:43 ` [pbs-devel] [PATCH proxmox-backup 1/2] ui: tape: restore: improve variable names Dominik Csapak
2023-11-10 12:03 ` [pbs-devel] applied: " Thomas Lamprecht
2023-11-10 12:04 ` Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60e51b2c-b3cb-0a68-3aa9-918aa350935e@proxmox.com \
--to=m.limbeck@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox