From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 1/2] api: create default prune job on datastore creation
Date: Wed, 29 Nov 2023 14:31:29 +0100 [thread overview]
Message-ID: <603145b9-1474-478a-b5fa-b418bb0701b4@proxmox.com> (raw)
In-Reply-To: <1701264220.irmoe4u1io.astroid@yuna.none>
Am 29/11/2023 um 14:27 schrieb Fabian Grünbichler:
> On November 29, 2023 12:36 pm, Christian Ebner wrote:
>> Create a default prune job when a datastore is created as part of a
>> disk/zpool creation transaction via e.g.:
>> `proxmox-backup-manager disk fs create <storage-name> --disk <block-device>
>> --add-datastore true`
> is this documented anywhere?
>
> `proxmox-backup-manager datastore create ..` does not add any
> schedules/jobs by default, it's just the web UI that does (but that also
> tells you about this, and allows you to override it!)
>
> I agree that it probably makes sense, but it should be consistent
> - web UI does it, but then it should display it (and it would need to
> become a new optional parameter here, maybe by extending
> "add_datastore", else overriding would not be possible)
> - proxmox-backup-manager does it, but then it should also do it for a
> "plain" datastore creation by default?
yeah, API might be indeed odd, especially if it happens unconditionally.
It might be better in general to add a hint to the UI (e.g., the datastore
summary) if there's no prune job and/or no garbage-collection schedule.
next prev parent reply other threads:[~2023-11-29 13:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 11:36 [pbs-devel] [PATCH proxmox-backup 0/2] add default prune job and gc-schedule Christian Ebner
2023-11-29 11:36 ` [pbs-devel] [PATCH proxmox-backup 1/2] api: create default prune job on datastore creation Christian Ebner
2023-11-29 13:27 ` Fabian Grünbichler
2023-11-29 13:31 ` Thomas Lamprecht [this message]
2023-11-29 13:54 ` Christian Ebner
2023-11-29 11:36 ` [pbs-devel] [PATCH proxmox-backup 2/2] api: create default garbage collection schedule Christian Ebner
2023-11-29 13:27 ` Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=603145b9-1474-478a-b5fa-b418bb0701b4@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox