Re: [PATCH v1 proxmox 2/2] fix #7690: proxmox-sys: close fd before rename/unlink in replace_file

[Christian Ebner <c.ebner@proxmox.com>]

On 6/30/26 3:24 PM, Robert Obkircher wrote:
> 
> On 29.06.26 13:18, Christian Ebner wrote:
>> On 6/17/26 12:49 PM, Robert Obkircher wrote:
>>> Fix the rename operation on WORM file systems and allow FUSE file
>>> systems to unlink without creating temporary .fuse_hidden files.
>>
>> question: what about other helpers using a similar pattern when
>> removing a temp file in error case, e.g. unlink() after file content
>> writing or fsync() failed while still holding an open file
>> descriptor in atomic_open_or_create_file()? These will produce the
>> .fuse_hidden files as well?
> I think so, but .fuse_hidden files are not really harmful, and it
> seems like we mostly use that function for lockfiles outside of
> datastores.

Okay, thanks for clarification. Was unsure if these could cause issues 
for the mentioned WORM filesystem implementation as well, so wanted to 
mention these as well.

> Should I write a test to verify when .fuse_hidden files are created? I
> didn't bother because I wasn't sure how to create a fuse file system
> in a test.

Not really worth the effort for the time being, unless we do want to 
explicitly support such FUSE based filesystems in the near future. 
Correct me if I'm wrong, but I'm not aware of active efforts to do so.

> But it also seems a bit strange to me that we use mkostemp and
> path-based renames in the first place. Creating the file
> with O_TMPFILE and linking it into place would definitely be safer.