From: Dominik Csapak <d.csapak@proxmox.com>
To: "Dominic Jäger" <d.jaeger@proxmox.com>,
"Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 0/4] remote edit: error message ideas
Date: Wed, 27 Jan 2021 14:57:17 +0100 [thread overview]
Message-ID: <5c9d20b0-69ae-d181-3511-08878d899ff4@proxmox.com> (raw)
In-Reply-To: <20210127105545.GA8912@mala>
On 1/27/21 11:55 AM, Dominic Jäger wrote:
> Thanks for looking at it!
>
> On Tue, Jan 26, 2021 at 11:34:54AM +0100, Dominik Csapak wrote:
>> when we have the error icon, we'd not need the asterisk,
>> since they both show the error
> We could theoretically show the asterisk without any color, just to symbolise
> "Required". But the error message shows this problem, too. So yes, it is
> redundant in some way.
ok
>
>> or were they not intended to be applied together?
> It was intended to be applicable together, but only to easily show the
> possibilities together. Not because I absolutely want all of the patches to be
> applied.
make sense
>
>> also, the generic tooltip does always show on the whole
>> element for me, so with either the asterisk or the
>> icon, i still get multiple tooltips over one another
> Same for me. But the error message should appear only if you hover over the
> asterisk or the symbol. This means
> 1. if you hover over the error symbol, the error message is above the generic
> tooltip. Then you see what is wrong.
> 2. if you hover over the field, the error message vanishes and you see what you
> are supposed to enter into the field.
>
> Without msgTarget: side the error tooltip should also appear if you hover over
> the input field. Then you only see the generic tooltip when you hover over the
> label, which is a little less intuitive than 2., I think.
the problem is rather that multiple tooltips above each other is ugly
and looks like something is wrong with the ui, so i'd like
to avoid that if possible
>>
>> another problem is with the detection of the 'required'
>> error. while this may work on english, extjs
>> errors are also translated, though i noticed we do
>> not do this yet for pbs (for pve we do)
>> so filtering by 'required' cannot work for other languages
> Makes sense, I missed that.
as we discussed off-list, we could simply check
if the field is empty instead
>>
>> and last but not least:
>> would it not be possible to show the tooltip just on the
>> label?
>> e.g.:
>>
>> ---
>> fieldLabel: `<div qtip="sometext">${gettext('labeltext')}</div>'
>> ---
> I could not get this to work yet and I am not sure if it is possible?
> The "Remote" field has xtype pmxDisplayEditField
works here (with the correct attribute ;) ):
---
fieldLabel: `<span data-qtip="some tooltip text">${gettext("Label")}</span>`
---
but i noticed it's even easier to do:
---
labelAttrTpl: 'data-qtip="Some Tooltip Text"',
---
puts that into the attributes of the whole label
>
>> Ext.define('Proxmox.form.field.DisplayEdit', {
>> extend: 'Ext.form.FieldContainer',
>> alias: 'widget.pmxDisplayEditField',
>
> and then fieldLabel is just a String, no HTML?
> https://docs.sencha.com/extjs/6.0.1/classic/Ext.form.FieldContainer.html#cfg-fieldLabel
>
>>
>> a little bit less intuitive, but should not create overlapping
>> tooltips
> This means we would have the same messages visible as currently?
> 1. Generic tool while hovering over label
> 2. Error message else (= hovering over field)
yes, but no overlapping tooltips
>
>>
>> another alternative would be to add a displayfield below the
>> field with an explanation?
> Sounds good to me. Downside in comparison to tooltips would be limited amount
> of text for the hints?
>
yeah pretty much
>>
>> or simply add a screenshot with a list of fields to the documentation?
> List of fields + what belongs into them? Isn't that quite much work to look up
> "just" to fill out a field?
>
but the admin usually needs that info only the first (few) times.
after that it just takes up space
next prev parent reply other threads:[~2021-01-27 13:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 11:09 Dominic Jäger
2021-01-19 11:09 ` [pbs-devel] [PATCH proxmox-backup 1/4] ui: remote edit: Add tooltips Dominic Jäger
2021-01-19 11:09 ` [pbs-devel] [PATCH proxmox-backup 2/4] ui: remote edit: Add asterisks Dominic Jäger
2021-01-19 11:09 ` [pbs-devel] [PATCH proxmox-backup 3/4] ui: remote edit: Error as symbol to the right Dominic Jäger
2021-01-19 11:09 ` [pbs-devel] [PATCH proxmox-backup 4/4] ui: remote edit: Change asterisk color Dominic Jäger
2021-01-26 10:34 ` [pbs-devel] [PATCH proxmox-backup 0/4] remote edit: error message ideas Dominik Csapak
2021-01-27 10:55 ` Dominic Jäger
2021-01-27 13:57 ` Dominik Csapak [this message]
2021-01-27 14:39 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c9d20b0-69ae-d181-3511-08878d899ff4@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=d.jaeger@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox