From: Stefan Reiter <s.reiter@proxmox.com>
To: Dietmar Maurer <dietmar@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [RFC 0/2] backup client: implement some HTTP timeouts
Date: Mon, 21 Dec 2020 16:49:22 +0100 [thread overview]
Message-ID: <5c0cbe82-1cd1-aeae-6363-097ca054506f@proxmox.com> (raw)
In-Reply-To: <1412279965.2136.1608565017552@webmail.proxmox.com>
On 12/21/20 4:36 PM, Dietmar Maurer wrote:
>> Not a comprehensive overhaul, but should fix the most common hangs to at least
>> finish *sometime*.
>
> We already have TCP timeouts. So why exactly do we need those short timeouts?
>
It's not a TCP timeout if the server hangs. This prevents the case where
the client has a connection established but the server fails to send
data within the given time.
Came up during discussion of this report:
https://forum.proxmox.com/threads/qmp-command-backup-failed-got-timeout.77749/#post-357700
where high load on the server (from too many verification tasks, which
is a different problem) causes VM clients to hang for unreasonable
amounts of time.
(Note that with QEMU 5.2 we can easily do the 'connect' async in the
background as well, preventing the full VM to hang, but we still need
some way to timeout the connection attempt, lest it stays active in the
background)
next prev parent reply other threads:[~2020-12-21 15:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-21 13:56 Stefan Reiter
2020-12-21 13:56 ` [pbs-devel] [RFC proxmox 1/2] add tools::future with TimeoutFutureExt Stefan Reiter
2020-12-21 13:56 ` [pbs-devel] [RFC proxmox-backup 2/2] http_client: add timeouts for critical connects Stefan Reiter
2020-12-21 15:36 ` [pbs-devel] [RFC 0/2] backup client: implement some HTTP timeouts Dietmar Maurer
2020-12-21 15:45 ` Dietmar Maurer
2020-12-21 15:49 ` Stefan Reiter [this message]
2020-12-21 16:40 ` Dietmar Maurer
2020-12-22 8:47 ` Stefan Reiter
2020-12-22 10:40 ` Dietmar Maurer
2020-12-22 12:32 ` [pbs-devel] applied: " Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c0cbe82-1cd1-aeae-6363-097ca054506f@proxmox.com \
--to=s.reiter@proxmox.com \
--cc=dietmar@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox