From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dietmar Maurer <dietmar@proxmox.com>,
Hannes Laimer <h.laimer@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] add inspection in proxmox-backup-manager for .blob, .didx and .fidx files
Date: Wed, 9 Dec 2020 10:32:27 +0100 [thread overview]
Message-ID: <5b8c2262-b6c6-09f5-d224-f6f95a1b38d7@proxmox.com> (raw)
In-Reply-To: <1493873668.1116.1607504621900@webmail.proxmox.com>
On 09.12.20 10:03, Dietmar Maurer wrote:
>> On 12/09/2020 9:42 AM Hannes Laimer <h.laimer@proxmox.com> wrote:
...
>> +pub fn inspect_commands() -> CommandLineInterface {
>> +
>> + let cmd_def = CliCommandMap::new()
>> + .insert("blob",CliCommand::new(&API_METHOD_INSPECT_BLOB))
>> + .insert("fidx",CliCommand::new(&API_METHOD_INSPECT_FIXED_INDEX))
>> + .insert("didx",CliCommand::new(&API_METHOD_INSPECT_DYNAMIC_INDEX));
>
> Can't we autodetect the file type?
>
proxmox-backup-client.rs has a 'parse_archive_type' function we maybe can reuse here,
it's used there when passing an "archive-name" on restore.
prev parent reply other threads:[~2020-12-09 9:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 8:42 Hannes Laimer
2020-12-09 9:03 ` Dietmar Maurer
2020-12-09 9:32 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b8c2262-b6c6-09f5-d224-f6f95a1b38d7@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=dietmar@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox