public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox Backup Server development discussion"
	<pbs-devel@lists.proxmox.com>,
	"Dominik Csapak" <d.csapak@proxmox.com>,
	"Dominic Jäger" <d.jaeger@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 0/4] remote edit: error message ideas
Date: Wed, 27 Jan 2021 15:39:43 +0100	[thread overview]
Message-ID: <5ad33d3d-3d03-b228-025e-338373138d42@proxmox.com> (raw)
In-Reply-To: <5c9d20b0-69ae-d181-3511-08878d899ff4@proxmox.com>

On 27.01.21 14:57, Dominik Csapak wrote:
> On 1/27/21 11:55 AM, Dominic Jäger wrote:
>> Thanks for looking at it!
>>
>> On Tue, Jan 26, 2021 at 11:34:54AM +0100, Dominik Csapak wrote:
>>> when we have the error icon, we'd not need the asterisk,
>>> since they both show the error
>> We could theoretically show the asterisk without any color, just to symbolise
>> "Required". But the error message shows this problem, too. So yes, it is
>> redundant in some way.
> 
> ok

FWIW: one of my initial ideas which resulted Dominic to look into this
was separation of the field required and the other field invalid states
(out of range, not matching a regex, to long/short, ...).

The rational consisted at least of (may have forgotten something, it was
quite a bit ago):
* By default conflicts with other tooltips. Yes, other invalid tooltips
  do so too, but they require input which normally happens after initial
  evaluation of the fields and their meaning by the user
* less red and invalidity when opening a fresh inputpanel/editwindow
  while still keeping a visual hint about required fields
* it's also a well established pattern and very common in user-interface,
  thus not new for users.

(just FYI)

>>>
>>> ---
>>> fieldLabel: `<div qtip="sometext">${gettext('labeltext')}</div>'
>>> ---
>> I could not get this to work yet and I am not sure if it is possible?
>> The "Remote" field has xtype pmxDisplayEditField
> 
> works here (with the correct attribute ;) ):
> ---
> fieldLabel: `<span data-qtip="some tooltip text">${gettext("Label")}</span>`
> ---
> 
> but i noticed it's even easier to do:
> 
> ---
> labelAttrTpl: 'data-qtip="Some Tooltip Text"',
> ---
> 
> puts that into the attributes of the whole label

Doesn't this rather replaces the whole attributes, if any, and may thus have
some side effects (e.g., ARIA ones) depending on what the component had defined
in this template?

If that is guaranteed to be a non-issue this would be surely nicer.






      reply	other threads:[~2021-01-27 14:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-19 11:09 Dominic Jäger
2021-01-19 11:09 ` [pbs-devel] [PATCH proxmox-backup 1/4] ui: remote edit: Add tooltips Dominic Jäger
2021-01-19 11:09 ` [pbs-devel] [PATCH proxmox-backup 2/4] ui: remote edit: Add asterisks Dominic Jäger
2021-01-19 11:09 ` [pbs-devel] [PATCH proxmox-backup 3/4] ui: remote edit: Error as symbol to the right Dominic Jäger
2021-01-19 11:09 ` [pbs-devel] [PATCH proxmox-backup 4/4] ui: remote edit: Change asterisk color Dominic Jäger
2021-01-26 10:34 ` [pbs-devel] [PATCH proxmox-backup 0/4] remote edit: error message ideas Dominik Csapak
2021-01-27 10:55   ` Dominic Jäger
2021-01-27 13:57     ` Dominik Csapak
2021-01-27 14:39       ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ad33d3d-3d03-b228-025e-338373138d42@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=d.jaeger@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal