From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Hannes Laimer <h.laimer@proxmox.com>
Subject: Re: [pbs-devel] [PATCH v2 proxmox-backup 1/4] pbs-api-types: add maintenance-type and msg to ds config
Date: Tue, 12 Oct 2021 10:51:47 +0200 [thread overview]
Message-ID: <5a8340d6-8277-d2cc-0eb2-e65984126168@proxmox.com> (raw)
In-Reply-To: <20211006151457.18508-2-h.laimer@proxmox.com>
any reason why you did not combine the type+message like i suggested?
in general it's ok to do it this way, but maybe giving a reason
(at least in the patch changelog) would be good
On 10/6/21 17:14, Hannes Laimer wrote:
> ---
> pbs-api-types/src/datastore.rs | 33 +++++++++++++++++++++++++++++++++
> 1 file changed, 33 insertions(+)
>
> diff --git a/pbs-api-types/src/datastore.rs b/pbs-api-types/src/datastore.rs
> index 75f82ea4..d1f3db9a 100644
> --- a/pbs-api-types/src/datastore.rs
> +++ b/pbs-api-types/src/datastore.rs
> @@ -165,6 +165,26 @@ pub struct PruneOptions {
> pub keep_yearly: Option<u64>,
> }
>
> +#[api()]
> +#[derive(PartialOrd, Debug, Copy, Clone, PartialEq, Serialize, Deserialize)]
> +#[serde(rename_all = "lowercase")]
> +/// Different maintenance types.
> +pub enum MaintenanceType {
> + /// Only reading operations are allowed.
> + ReadOnly,
> + /// Neither reading nor writing is allowed on the datastore.
> + Offline,
> +}
> +
> +impl std::fmt::Display for MaintenanceType {
> + fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
> + match *self {
> + MaintenanceType::ReadOnly => write!(f, "read-only"),
> + MaintenanceType::Offline => write!(f, "offline"),
> + }
> + }
> +}
> +
> #[api(
> properties: {
> name: {
> @@ -222,6 +242,15 @@ pub struct PruneOptions {
> optional: true,
> type: bool,
> },
> + "maintenance-type": {
> + optional: true,
> + type: MaintenanceType,
> + },
> + "maintenance-msg": {
> + description: "Text that will be shown as a description for the maintenance.",
> + optional: true,
> + type: String,
> + },
> }
> )]
> #[derive(Serialize,Deserialize,Updater)]
> @@ -259,6 +288,10 @@ pub struct DataStoreConfig {
> /// Send notification only for job errors
> #[serde(skip_serializing_if="Option::is_none")]
> pub notify: Option<String>,
> + #[serde(skip_serializing_if="Option::is_none")]
> + pub maintenance_type: Option<MaintenanceType>,
> + #[serde(skip_serializing_if="Option::is_none")]
> + pub maintenance_msg: Option<String>,
> }
>
> #[api(
>
next prev parent reply other threads:[~2021-10-12 8:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-06 15:14 [pbs-devel] [PATCH v2 proxmox-backup 0/4] close #3071: maintenance mode for datastores Hannes Laimer
2021-10-06 15:14 ` [pbs-devel] [PATCH v2 proxmox-backup 1/4] pbs-api-types: add maintenance-type and msg to ds config Hannes Laimer
2021-10-12 8:51 ` Dominik Csapak [this message]
2021-10-06 15:14 ` [pbs-devel] [PATCH v2 proxmox-backup 2/4] pbs-datastore: add check for maintenance to lookup_datastore Hannes Laimer
2021-10-12 8:51 ` Dominik Csapak
2021-10-06 15:14 ` [pbs-devel] [PATCH v2 proxmox-backup 3/4] api2: make maintenance type and msg updatable/deletable Hannes Laimer
2021-10-12 8:51 ` Dominik Csapak
2021-10-06 15:14 ` [pbs-devel] [PATCH v2 proxmox-backup 4/4] ui: add maintenance to datastore options Hannes Laimer
2021-10-12 8:51 ` Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a8340d6-8277-d2cc-0eb2-e65984126168@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox