[pbs-devel] [PATCH proxmox-backup] datastore: remove unsafe from function

[pbs-devel] [PATCH proxmox-backup] datastore: remove unsafe from function

[Gabriel Goller]

`list_snapshots_blocking` doesn't need to be unsafe.

Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---
 src/api2/admin/datastore.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/api2/admin/datastore.rs b/src/api2/admin/datastore.rs
index 82221c503d16..f28fb97fa975 100644
--- a/src/api2/admin/datastore.rs
+++ b/src/api2/admin/datastore.rs
@@ -451,7 +451,7 @@ pub async fn list_snapshots(
 ) -> Result<Vec<SnapshotListItem>, Error> {
     let auth_id: Authid = rpcenv.get_auth_id().unwrap().parse()?;
 
-    tokio::task::spawn_blocking(move || unsafe {
+    tokio::task::spawn_blocking(move || {
         list_snapshots_blocking(store, ns, backup_type, backup_id, auth_id)
     })
     .await
@@ -459,7 +459,7 @@ pub async fn list_snapshots(
 }
 
 /// This must not run in a main worker thread as it potentially does tons of I/O.
-unsafe fn list_snapshots_blocking(
+fn list_snapshots_blocking(
     store: String,
     ns: Option<BackupNamespace>,
     backup_type: Option<BackupType>,
-- 
2.43.0



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

Re: [pbs-devel] [PATCH proxmox-backup] datastore: remove unsafe from function

[Christian Ebner]

On 7/3/24 16:58, Gabriel Goller wrote:
> `list_snapshots_blocking` doesn't need to be unsafe.

I think that this is intentionally marked as `unsafe` to make sure the 
caller really does look at the possible consequences of calling this 
method. As documented, "This must not run in a main worker thread as it 
potentially does tons of I/O."

So rather than dropping the `unsafe`, maybe clarify that this is the 
reason for it being declared as unsafe in the comment.

But I guess Wolfgang can comment more on this.



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

Re: [pbs-devel] [PATCH proxmox-backup] datastore: remove unsafe from function

[Gabriel Goller]

On 04.07.2024 11:59, Christian Ebner wrote:
>On 7/3/24 16:58, Gabriel Goller wrote:
>>`list_snapshots_blocking` doesn't need to be unsafe.
>
>I think that this is intentionally marked as `unsafe` to make sure the 
>caller really does look at the possible consequences of calling this 
>method. As documented, "This must not run in a main worker thread as 
>it potentially does tons of I/O."
>
>So rather than dropping the `unsafe`, maybe clarify that this is the 
>reason for it being declared as unsafe in the comment.
>
>But I guess Wolfgang can comment more on this.
>

Oh, well, didn't know that. Will add a comment :)


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel