From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Christian Ebner <c.ebner@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup] pxar: client: fix missing file size check for metadata comparison
Date: Mon, 9 Dec 2024 13:00:41 +0100 [thread overview]
Message-ID: <59ce86b9-545f-4e7f-aee8-973e0f1aa49c@proxmox.com> (raw)
In-Reply-To: <20241208193445.37493-1-c.ebner@proxmox.com>
Am 08.12.24 um 20:34 schrieb Christian Ebner:
> Change detection mode set to metadata compares regular file entries
> metadata to the reference metadata archive of the previous run. The
> `pxar::format::Stat` as stored in `pxar::Metadata` however does not
> include the actual file size, it only partially stores information
> gathered from stating the file.
>
> This means however that the actual file size is never compared and
> therefore, that if the file size did change, but the other metadata
> information did not (including the mtime which might have been
> restored), that file will be incorrectly reused.
> A subsequent restore will however fail, because the expected file size
> as encoded in the metadata archive does not match the file size as
> stored in the payload archive.
>
> Fix this by adding the missing file size check, comparing the size
> for the given file against the one stored in the metadata archive.
>
> Link to issue reported in community forum:
> https://forum.proxmox.com/threads/158722/
>
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
> pbs-client/src/pxar/create.rs | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
>
applied, thanks!
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2024-12-09 12:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-08 19:34 [pbs-devel] " Christian Ebner
2024-12-09 12:00 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59ce86b9-545f-4e7f-aee8-973e0f1aa49c@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox