From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup] ui: tape: fix restore datastore mapping parameter construction
Date: Tue, 6 Jun 2023 13:14:35 +0200 [thread overview]
Message-ID: <599a7b07-01cc-89a7-083b-dd0e078b23ad@proxmox.com> (raw)
In-Reply-To: <20230606092045.1782511-1-d.csapak@proxmox.com>
Am 06/06/2023 um 11:20 schrieb Dominik Csapak:
> We recently took into account the selected datastore when restoring from
> tape, but the snapshot grids value may not only be a single datastore, it can
> also be a list of snapshots, datastores or 'all'.
>
> handle these cases and extract the source datastore correctly.
>
> This fixes tape restoration when not a whole datastore is selected.
>
> Reported in the forum:
> https://forum.proxmox.com/threads/restore-from-lto-parameter-verification-errors-store.128445
>
> Fixes: df881ed0 ("ui: tape: fix restoring a single datastore")
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> this patch should also apply cleanly on the stable-2 branch currently
>
> www/tape/window/TapeRestore.js | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
>
applied, thanks!
A bit unrelated from this, but the code here would benefit IMO from ensuring
that for every variable/viewModel entry with datastore in its name, it is made
clear if that is talking about the source or the target...
prev parent reply other threads:[~2023-06-06 11:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 9:20 [pbs-devel] " Dominik Csapak
2023-06-06 11:14 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=599a7b07-01cc-89a7-083b-dd0e078b23ad@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox