From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Shannon Sterz <s.sterz@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup] api: move DataStoreConfig parsing and mount check after allowed check
Date: Mon, 16 Dec 2024 13:42:00 +0100 [thread overview]
Message-ID: <590a547c-5768-40aa-8832-14c8d8535d73@proxmox.com> (raw)
In-Reply-To: <20241216115044.208595-1-s.sterz@proxmox.com>
Am 16.12.24 um 12:50 schrieb Shannon Sterz:
> this moves the parsing of the concrete DataStoreConfig as well as the
> check whether a store is mounted after the authorization checks.
> otherwise we always check for all datastore whether they are mounted,
> even if the requesting user has no privileges to list the specified
> datastore anyway.
>
> this may improve performance for large setups, as we won't need to stat
> mounted datastores regardless of the useres privileges. this was
> suggested on the mailing list [1].
>
> [1]: https://lore.proxmox.com/pbs-devel/embeb48874-d400-4e69-ae0f-2cc56a39d592@93f95f61.com/
>
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> ---
> src/api2/admin/datastore.rs | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
>
applied, thanks!
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2024-12-16 12:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-16 11:50 [pbs-devel] " Shannon Sterz
2024-12-16 12:42 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=590a547c-5768-40aa-8832-14c8d8535d73@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=s.sterz@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal