From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH proxmox-backup 3/4] tape: implement 6 byte fallback for MODE SENSE/SELECT
Date: Thu, 30 Mar 2023 15:38:59 +0200 [thread overview]
Message-ID: <55d3ba8f-c1d4-20b5-7f12-051c21849403@proxmox.com> (raw)
In-Reply-To: <20230330112845.2620964-3-d.csapak@proxmox.com>
On 3/30/23 13:28, Dominik Csapak wrote:
> there are tape drives (esp. virtual ones) that don't implement the
> 10-byte variants of MODE SENSE/SELECT. Since the pages we set/request
> are never bigger than 255 bytes anyway, we can implement a fallback
> with the 6 byte variant here.
>
> Implementing this as a fallback to make sure that existing working
> drives keep the existing implementation.
>
> Tested with Starwind VTL.
>
note because if forgot: this patch does not fix pbs tape usage
with starwinds vtl completely, there are some things that still
don't work, but this fixes these specific commands there and
may increase compatibility with other drives too
next prev parent reply other threads:[~2023-03-30 13:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 11:28 [pbs-devel] [PATCH proxmox-backup 1/4] tape: use correct MAM attribute definitions Dominik Csapak
2023-03-30 11:28 ` [pbs-devel] [PATCH proxmox-backup 2/4] tape: continue without MAM media_usage page Dominik Csapak
2023-04-20 12:19 ` [pbs-devel] applied " Dietmar Maurer
2023-03-30 11:28 ` [pbs-devel] [PATCH proxmox-backup 3/4] tape: implement 6 byte fallback for MODE SENSE/SELECT Dominik Csapak
2023-03-30 13:38 ` Dominik Csapak [this message]
2023-03-30 11:28 ` [pbs-devel] [PATCH proxmox-backup 4/4] tape: typo fixes Dominik Csapak
2023-04-20 12:18 ` [pbs-devel] applied [PATCH proxmox-backup 1/4] tape: use correct MAM attribute definitions Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55d3ba8f-c1d4-20b5-7f12-051c21849403@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox