From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Hannes Laimer <h.laimer@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup v2] api: add Sys.Modify on /system/disks as permission to endpoints handling removable datastores
Date: Tue, 26 Nov 2024 16:25:01 +0100 [thread overview]
Message-ID: <556ea392-f2fc-4ba7-9e4b-372bfb090c1b@proxmox.com> (raw)
In-Reply-To: <20241126142840.136533-1-h.laimer@proxmox.com>
Am 26.11.24 um 15:28 schrieb Hannes Laimer:
> Suggested-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
> changes since v1:
> * config: create/delete: only check for Sys.Modify on /system/disks if
> removable
>
> src/api2/admin/datastore.rs | 12 +++++++++---
> src/api2/config/datastore.rs | 13 ++++++++++++-
> 2 files changed, 21 insertions(+), 4 deletions(-)
>
>
applied, with subject slightly improved and the descriptions for the dynamic
access checks squashed in, thanks!
You can send Fabian's other suggestion to switch to Datastore.Modify as
follow-up.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2024-11-26 15:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-26 14:28 [pbs-devel] " Hannes Laimer
2024-11-26 15:12 ` Fabian Grünbichler
2024-11-26 15:20 ` Hannes Laimer
2024-11-26 15:25 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556ea392-f2fc-4ba7-9e4b-372bfb090c1b@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox