public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pbs-devel] [PATCH proxmox-backup] server: sync email notification: adapt template for local sync jobs
@ 2023-11-29 16:35 Lukas Wagner
  2023-11-29 16:40 ` [pbs-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Lukas Wagner @ 2023-11-29 16:35 UTC (permalink / raw)
  To: pbs-devel

Add a guard clause that checks `job.remote`, otherwise the template
fails to render to to handlebars being configured in strict mode.

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
 src/server/email_notifications.rs | 26 ++++++++++++++++----------
 1 file changed, 16 insertions(+), 10 deletions(-)

diff --git a/src/server/email_notifications.rs b/src/server/email_notifications.rs
index 18881782..43b55656 100644
--- a/src/server/email_notifications.rs
+++ b/src/server/email_notifications.rs
@@ -90,11 +90,14 @@ Please visit the web interface for further details:
 
 const SYNC_OK_TEMPLATE: &str = r###"
 
-Job ID:       {{job.id}}
-Datastore:    {{job.store}}
-Remote:       {{job.remote}}
-Remote Store: {{job.remote-store}}
-
+Job ID:             {{job.id}}
+Datastore:          {{job.store}}
+{{#if job.remote~}}
+Remote:             {{job.remote}}
+Remote Store:       {{job.remote-store}}
+{{else~}}
+Local Source Store: {{job.remote-store}}
+{{/if}}
 Synchronization successful.
 
 
@@ -106,11 +109,14 @@ Please visit the web interface for further details:
 
 const SYNC_ERR_TEMPLATE: &str = r###"
 
-Job ID:       {{job.id}}
-Datastore:    {{job.store}}
-Remote:       {{job.remote}}
-Remote Store: {{job.remote-store}}
-
+Job ID:             {{job.id}}
+Datastore:          {{job.store}}
+{{#if job.remote~}}
+Remote:             {{job.remote}}
+Remote Store:       {{job.remote-store}}
+{{else~}}
+Local Source Store: {{job.remote-store}}
+{{/if}}
 Synchronization failed: {{error}}
 
 
-- 
2.39.2





^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pbs-devel] applied: [PATCH proxmox-backup] server: sync email notification: adapt template for local sync jobs
  2023-11-29 16:35 [pbs-devel] [PATCH proxmox-backup] server: sync email notification: adapt template for local sync jobs Lukas Wagner
@ 2023-11-29 16:40 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2023-11-29 16:40 UTC (permalink / raw)
  To: Proxmox Backup Server development discussion, Lukas Wagner

Am 29/11/2023 um 17:35 schrieb Lukas Wagner:
> Add a guard clause that checks `job.remote`, otherwise the template
> fails to render to to handlebars being configured in strict mode.
> 
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
>  src/server/email_notifications.rs | 26 ++++++++++++++++----------
>  1 file changed, 16 insertions(+), 10 deletions(-)
> 
>

applied, thanks!




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-11-29 16:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-29 16:35 [pbs-devel] [PATCH proxmox-backup] server: sync email notification: adapt template for local sync jobs Lukas Wagner
2023-11-29 16:40 ` [pbs-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal