Re: [pbs-devel] [PATCH proxmox-backup stable-3 0/3] Backport group listing optimizations including bugfix

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 27.10.25 um 10:33 schrieb Christian Ebner:
> These patches were part of the patch series to introduce the
> streaming content api for PBS [0], optimizing the backup group
> listing.
> 
> They did however indirectly fix also a bug in the group listing
> api call, which lead to the `last-backup` time to be returned
> incorrectly in some occasions. This was found and disected in
> issue 6956 [1], identifying an incorrect is_finished() check while
> folding the snapshot iterator to determine the last finished snapshot
> of a group.
> 
> Therefore, instead of just fixing the bug, backport the relevant
> patches which also provides the group listing improvements.

They all miss your S-o-b trailer, and ideally add the original commit
they got backported from, if you use `git -xs cherry-pick <ref>` all
this happens automatically.

> 
> While the first 2 patches are preparatory, the last patch actually
> fixes the issue.
> 
> [0] https://lore.proxmox.com/pbs-devel/20251008134344.3512958-1-d.csapak@proxmox.com/T/#t
> [1] https://bugzilla.proxmox.com/show_bug.cgi?id=6956
> 
> Dominik Csapak (3):
>   api: admin: datastore: refactor BackupGroup to GroupListItem
>     conversion
>   api: admin: datastore: factor out 'get_group_owner'
>   api: admin: datastore: optimize `groups` api call
> 
>  src/api2/admin/datastore.rs | 134 +++++++++++++++++++++---------------
>  1 file changed, 77 insertions(+), 57 deletions(-)
> 



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel