public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Mira Limbeck <m.limbeck@proxmox.com>
Subject: [pbs-devel] applied: [PATCH v2 proxmox-backup 1/2] add extra_info field to APTUpdateInfo
Date: Wed, 11 Nov 2020 18:33:47 +0100	[thread overview]
Message-ID: <5326ebc6-b85b-1427-a381-793bd2f5fbd4@proxmox.com> (raw)
In-Reply-To: <20201110132218.17717-1-m.limbeck@proxmox.com>

On 10.11.20 14:22, Mira Limbeck wrote:
> Add an optional string field to APTUpdateInfo which can be used for
> extra information.
> 
> This is used for passing running kernel and running version information
> in the versions API call together with proxmox-backup and
> proxmox-backup-server.
> 
> Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
> ---
> v2:
>     - renamed additional_info to extra_info to make it compatible with
>       GUI code
>     - changed the running_kernel and running_version info to contain the
>       text 'running kernel: ' and 'running version: ' which removes the
>       need for special casing in proxmox-backup-manager versions and
>       makes it again compatible with the GUI
> 
>  src/api2/node/apt.rs  | 35 ++++++++++++++++++++++++++++-------
>  src/api2/types/mod.rs |  2 ++
>  src/tools/apt.rs      |  1 +
>  3 files changed, 31 insertions(+), 7 deletions(-)
> 
>

applied, thanks! I did some followups restoring the format to the previous state,
line lengths up to 99 are fine for us, and reducing some lines can help read the
code faster as more is visible and thus in the mental state, at least it feels
less bloated to me :-)

Can you please address your comment on this patch as followup?





      parent reply	other threads:[~2020-11-11 17:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-10 13:22 [pbs-devel] " Mira Limbeck
2020-11-10 13:22 ` [pbs-devel] [PATCH v2 proxmox-backup 2/2] add versions command to proxmox-backup-manager Mira Limbeck
2020-11-11 17:38   ` [pbs-devel] applied: " Thomas Lamprecht
2020-11-12  9:12     ` [pbs-devel] [PATCH proxmox-backup] apt: use typed response for get_versions Stefan Reiter
2020-11-12  9:18       ` [pbs-devel] applied: " Thomas Lamprecht
     [not found]     ` <c16a8594-0f66-eadb-1063-d6309187a4e5@proxmox.com>
2020-11-12  9:29       ` [pbs-devel] applied: [PATCH v2 proxmox-backup 2/2] add versions command to proxmox-backup-manager Thomas Lamprecht
2020-11-11 11:59 ` [pbs-devel] [PATCH v2 proxmox-backup 1/2] add extra_info field to APTUpdateInfo Mira Limbeck
2020-11-11 17:33 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5326ebc6-b85b-1427-a381-793bd2f5fbd4@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=m.limbeck@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal