Re: [pbs-devel] [PATCH proxmox-backup 1/2] api: create default prune job on datastore creation

[Christian Ebner <c.ebner@proxmox.com>]

> On 29.11.2023 14:27 CET Fabian Grünbichler <f.gruenbichler@proxmox.com> wrote:
> 
> is this documented anywhere?

No, there is no documentation on this. I will have to include that as well in a new
version of the patches.

> `proxmox-backup-manager datastore create ..` does not add any
> schedules/jobs by default, it's just the web UI that does (but that also
> tells you about this, and allows you to override it!)

Yes, that is indeed true. I would argue for an increased usability by a default
creation of prune job and garbage collection schedules with well documented defaults
for all possible datastore creation routes, and allow to override these defaults via
the optional parameters.
Are there objections to such a change in behavior? This should further
be considered a breaking change for the API, I suppose.
 
> 
> I agree that it probably makes sense, but it should be consistent
> - web UI does it, but then it should display it (and it would need to
>   become a new optional parameter here, maybe by extending
>   "add_datastore", else overriding would not be possible)
> - proxmox-backup-manager does it, but then it should also do it for a
>   "plain" datastore creation by default?

You are right in that these patches are not sufficient to create consistent behavior
for all possible cases. I will have to refine and extend this.

Thank you for your feedback!

Cheers,
Chris