public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox Backup Server development discussion"
	<pbs-devel@lists.proxmox.com>,
	"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] unbreak get_subscription without sshd installed
Date: Tue, 10 Nov 2020 17:54:07 +0100	[thread overview]
Message-ID: <51915fa2-338c-646c-3c0e-f0d6a4f7f8c0@proxmox.com> (raw)
In-Reply-To: <20201110155927.2650445-1-f.gruenbichler@proxmox.com>

On 10.11.20 16:59, Fabian Grünbichler wrote:
> which might be the case e.g. in a PBS container
> 

rather breaks it further, as in, one cannot use subscriptions at all
anymore...

> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
> 
> Notes:
>     we might want to switch to a different file as base? or even generate a file
>     just for the server ID derivation?

using the openssh-server one has quite some advantages, be it only to
avoid tampering. I'd for now suggest adding the diff below to the meta
package - we can see if another option makes more sense for the next
major release.

btw, a specific container meta package like PMG has, without the kernel
dependencies could make sense to add.

----8<----
diff --git a/debian/control b/debian/control
index e88b965..d961da0 100644
--- a/debian/control
+++ b/debian/control
@@ -7,6 +7,7 @@ Maintainer: Proxmox Support Team <support@proxmox.com>
 Package: proxmox-backup
 Architecture: all
 Depends: libc6,
+         openssh-server,
          proxmox-archive-keyring,
          proxmox-backup-client,
          proxmox-backup-server,
--





  parent reply	other threads:[~2020-11-10 16:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-10 15:59 Fabian Grünbichler
2020-11-10 16:01 ` Dietmar Maurer
2020-11-10 16:52   ` Fabian Grünbichler
2020-11-10 16:54 ` Thomas Lamprecht [this message]
2020-11-10 17:23   ` Fabian Grünbichler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51915fa2-338c-646c-3c0e-f0d6a4f7f8c0@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.gruenbichler@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal