Re: [PATCH v6 proxmox-backup 00/18] fix: #3847 pipe from STDIN to proxmox-backup-client

[Christian Ebner <c.ebner@proxmox.com>]

On 2/10/26 4:06 PM, Robert Obkircher wrote:
> Add support for commands like:
>      ssh host cmd | proxmox-backup-client backup data.img:/dev/stdin
>      proxmox-backup-client backup a.img:<(mysqldump) b.img:<(pgdump)
> 
> Changes since v5:
> 
> Client:
> - add IndexType::to_prefix_and_size helper and fix format string nit
> - drop support for '-' but log helpful warnings
> - fail early for duplicate pipes
> - avoid calling poll_next on terminated streams
> 
> Server:
> - mention why Arc<ChunkStore> can be removed from didx as well
> - (Test)TempDir:
>      - add to parent mod in earlier commit
>      - drop "Test" from the name
>      - improved API so it could be moved to a crate (no unwrap in new,
>        no Deref, no impl From<&TempDir> for PathBuf)
>      - added tests
> - reorder add_chunk commit before grow_to_size
> - support reuse-csum with arbitrary sizes
> - made up my mind on u32 vs u64 and reordered commits
> - check that chunk_size is power of two

This series has taken a really nice shape, got nothing to complain code 
wise and works as expected!

Tested:
  - several input stream variations, via pipe and command substitution
  - restores produce the same byte stream as the input data
  - char devices and pts are not allowed
  - reading from /dev/stdin is not allowed to be duplicated
  - subsequent backups work without issues
  - backup and restore of images with given size such as for VMs are 
unaffected

Reviewed-by: Christian Ebner <c.ebner@proxmox.com>
Tested-by: Christian Ebner <c.ebner@proxmox.com>