From: Christian Ebner <c.ebner@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH v5 proxmox 2/8] pbs api types: add option to set GC chunk cleanup atime cutoff
Date: Wed, 19 Mar 2025 10:08:49 +0100 [thread overview]
Message-ID: <4ff622ce-23ff-4b9a-9336-7d8aa4c7c6f2@proxmox.com> (raw)
In-Reply-To: <e0bc3b14-d1ee-4c73-a5d8-a4b21f809099@proxmox.com>
On 3/19/25 10:01, Thomas Lamprecht wrote:
> Am 19.03.25 um 09:48 schrieb Christian Ebner:
>> Given this I did check also the output in the docs, which however shows
>> the very unintuitive integer rage and default value.
>>
>> So given that, maybe it would be better to switch from an integer schema
>> to a string schema and parse the values as HumanTime?
>> Similar to what is done for the GC schedule.
>
> That might indeed have some benefits UX wise, albeit I'm not 100% sure how
> good this is in the web UI, or is there a pre-existing use case for
> HumanTime in the UI and thus ideally have already a nice validator there to
> provide quicker feedback to users if they enter something bogus.
I think this could be done in the schema validation function, but have
to take a closer look.
> As the GC schedule is a calendar event, i.e. time instants not really time
> durations like HumanTime is, e.g. `daily` or `hourly`, which calendar event
> support would not make that much sense here.
Yes, these would definitely need to be excluded.
> That said, while I have some slight reservations those probably could be
> resolved with some frontend validation, and it probably would not get
> worse than plain minutes, albeit I'd expect that most people either will
> reduce this to the minimum of 1 to ensure GC collects chunks without
> references much faster or leave it as is, so not sure how much hassle
> this is worth it, at least for this specific duration setting.
Okay, will take a closer look, if it requires to much adaption we can
keep it as integer schema (+ your improvement suggestions).
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-03-19 9:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 14:52 [pbs-devel] [PATCH v5 proxmox-backup 0/8] fix #5982: check atime update is honored Christian Ebner
2025-03-06 14:52 ` [pbs-devel] [PATCH v5 proxmox 1/8] pbs api types: add garbage collection atime safety check flag Christian Ebner
2025-03-06 14:52 ` [pbs-devel] [PATCH v5 proxmox 2/8] pbs api types: add option to set GC chunk cleanup atime cutoff Christian Ebner
2025-03-19 8:10 ` Thomas Lamprecht
2025-03-19 8:48 ` Christian Ebner
2025-03-19 9:01 ` Thomas Lamprecht
2025-03-19 9:08 ` Christian Ebner [this message]
2025-03-19 9:13 ` Thomas Lamprecht
2025-03-19 9:25 ` Christian Ebner
2025-03-06 14:52 ` [pbs-devel] [PATCH v5 proxmox-backup 3/8] fix #5982: garbage collection: check atime updates are honored Christian Ebner
2025-03-19 8:45 ` Thomas Lamprecht
2025-03-19 9:22 ` Christian Ebner
2025-03-06 14:52 ` [pbs-devel] [PATCH v5 proxmox-backup 4/8] ui: expose GC atime safety check flag in datastore tuning options Christian Ebner
2025-03-19 8:45 ` Thomas Lamprecht
2025-03-06 14:52 ` [pbs-devel] [PATCH v5 proxmox-backup 5/8] docs: mention GC atime update check for " Christian Ebner
2025-03-06 14:52 ` [pbs-devel] [PATCH v5 proxmox-backup 6/8] datastore: use custom GC atime cutoff if set Christian Ebner
2025-03-06 14:52 ` [pbs-devel] [PATCH v5 proxmox-backup 7/8] ui: expose GC atime cutoff in datastore tuning option Christian Ebner
2025-03-19 8:49 ` Thomas Lamprecht
2025-03-06 14:52 ` [pbs-devel] [PATCH v5 proxmox-backup 8/8] docs: mention gc-atime-cutoff as " Christian Ebner
2025-03-19 17:26 ` [pbs-devel] [PATCH v5 proxmox-backup 0/8] fix #5982: check atime update is honored Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ff622ce-23ff-4b9a-9336-7d8aa4c7c6f2@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal