From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup v2] fix #4274: implement prune notifications
Date: Fri, 7 Oct 2022 15:36:51 +0200 [thread overview]
Message-ID: <4f146682-3f1e-9e96-fb58-00233457811e@proxmox.com> (raw)
In-Reply-To: <20221006090812.1491248-1-d.csapak@proxmox.com>
Am 06/10/2022 um 11:08 schrieb Dominik Csapak:
> we converted the prune settings of datastores to prune-jobs, but did
> not actually implement the notifications for them, even though
> we had the notification options in the gui (they did not work).
>
> implement the basic ok/error notification for prune jobs
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> changes from v1:
> * include 'fix #' in the commit subject
> * call lookup_datastore_notify_settings directly in the send helper
> * fix compilation errors
> * rebase on master
> pbs-api-types/src/jobs.rs | 6 +++
> src/api2/config/datastore.rs | 1 +
> src/server/email_notifications.rs | 77 +++++++++++++++++++++++++++++++
> src/server/prune_job.rs | 7 ++-
> www/datastore/OptionView.js | 2 +-
> www/window/NotifyOptions.js | 2 +-
> 6 files changed, 91 insertions(+), 4 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2022-10-07 13:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-06 9:08 [pbs-devel] " Dominik Csapak
2022-10-07 13:36 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f146682-3f1e-9e96-fb58-00233457811e@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox