From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Gabriel Goller <g.goller@proxmox.com>
Subject: Re: [pbs-devel] [RFC proxmox-backup 0/2] Tasklog rewrite with tracing
Date: Wed, 18 Oct 2023 15:12:59 +0200 [thread overview]
Message-ID: <4e0de017-9fbf-4a5e-b735-62b955fe8a8b@proxmox.com> (raw)
In-Reply-To: <20231011140102.273423-1-g.goller@proxmox.com>
hi, a high level comments on this series:
you implemented a 'tasklog' = true filter, which is nice, but not filter for the syslog
in general we'd want to land things either in the task log (preferred) or in the syslog,
not in both (e.g. for some tasks this pollutes the syslog unnecessarily)
so i'd like to see also a syslog = false (or syslog = true) and maybe some
functionality to enable/disable that for whole block (if that's even possible?)
rest of the comment in the relevant patch
next prev parent reply other threads:[~2023-10-18 13:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 14:01 Gabriel Goller
2023-10-11 14:01 ` [pbs-devel] [RFC proxmox-backup 1/2] log: removed task_log! macro and moved to tracing Gabriel Goller
2023-10-11 14:01 ` [pbs-devel] [RFC proxmox 2/2] proxmox-log: added tracing infra Gabriel Goller
2023-10-13 12:36 ` Gabriel Goller
2023-10-18 13:26 ` Dominik Csapak
2023-10-23 8:56 ` Gabriel Goller
2023-10-23 9:11 ` Gabriel Goller
2023-10-18 13:12 ` Dominik Csapak [this message]
2023-10-23 9:09 ` [pbs-devel] [RFC proxmox-backup 0/2] Tasklog rewrite with tracing Gabriel Goller
2023-10-23 9:29 ` Dominik Csapak
2023-10-23 11:43 ` Gabriel Goller
2023-10-23 14:33 ` Thomas Lamprecht
2023-10-24 13:44 ` Gabriel Goller
2023-10-25 13:55 ` Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e0de017-9fbf-4a5e-b735-62b955fe8a8b@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox