From: Lukas Wagner <l.wagner@proxmox.com>
To: Wolfgang Bumiller <w.bumiller@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH v3 proxmox-backup 1/4] debug cli: show more file attributes for `diff archive` command
Date: Fri, 9 Dec 2022 11:45:58 +0100 [thread overview]
Message-ID: <4d6b3e2d-2cfa-0e38-1c9e-94bc79170dea@proxmox.com> (raw)
In-Reply-To: <20221209091352.qxph4w7hy6jfvjih@wobu-vie.proxmox.com>
On 12/9/22 10:13, Wolfgang Bumiller wrote:
>> + (EntryKind::Device(a), EntryKind::Device(b)) => {
>> + changed.content = a.major != b.major || a.minor != b.minor
>
> Just noticed - we might be missing a change between blockdev/chardev
> here? Might need to include
>
> file_a.metadata().stat.is_blockdev() != file_b.metadata().stat.is_blockdev()
>
> as well? Or am I missing this being handled elsewhere already?>
Yes, you are absolutely correct, this is something that I've missed here. Will be fixed in the next
version of the patch series.
--
Best Regards,
Lukas Wagner
next prev parent reply other threads:[~2022-12-09 10:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 9:38 [pbs-devel] [PATCH v3 proxmox-backup 0/4] debug cli: improve output, optionally compare file content for `diff archive` Lukas Wagner
2022-12-07 9:38 ` [pbs-devel] [PATCH v3 proxmox-backup 1/4] debug cli: show more file attributes for `diff archive` command Lukas Wagner
2022-12-09 9:13 ` Wolfgang Bumiller
2022-12-09 10:45 ` Lukas Wagner [this message]
2022-12-07 9:38 ` [pbs-devel] [PATCH v3 proxmox-backup 2/4] debug cli: add 'compare-content' flag to " Lukas Wagner
2022-12-07 9:38 ` [pbs-devel] [PATCH v3 proxmox-backup 3/4] debug cli: add colored output for `diff archive` Lukas Wagner
2022-12-07 9:38 ` [pbs-devel] [PATCH v3 proxmox-backup 4/4] debug cli: move parameters into the function signature Lukas Wagner
2022-12-09 9:22 ` Wolfgang Bumiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d6b3e2d-2cfa-0e38-1c9e-94bc79170dea@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox