From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Aaron Lauterer <a.lauterer@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 2/3] ui: onlinehelp update with sysadmin_host_administration
Date: Tue, 10 Nov 2020 13:53:08 +0100 [thread overview]
Message-ID: <4d5c6c92-ff04-ece6-9662-cbc3939d3d16@proxmox.com> (raw)
In-Reply-To: <20201110123850.21491-2-a.lauterer@proxmox.com>
On 10.11.20 13:38, Aaron Lauterer wrote:
> also remove some rst refs that slipped in
>
why?? this is an autogenerated file which we want to track in git, nothing slipped
in here. Do not remove things manually which then just get re-added on each make
OnlineHelpInfo call, producing a dirty git state..
I dropped the wrong removes, the correct fix for this is to fix the onlineHelp
scanner, which then drops this automatically.
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> www/OnlineHelpInfo.js | 40 ++++------------------------------------
> 1 file changed, 4 insertions(+), 36 deletions(-)
>
> diff --git a/www/OnlineHelpInfo.js b/www/OnlineHelpInfo.js
> index a9683874..c54912d8 100644
> --- a/www/OnlineHelpInfo.js
> +++ b/www/OnlineHelpInfo.js
> @@ -75,42 +75,6 @@ const proxmoxOnlineHelpInfo = {
> "link": "/docs/pve-integration.html#pve-integration",
> "title": "`Proxmox VE`_ Integration"
> },
> - "rst-primer": {
> - "link": "/docs/reStructuredText-primer.html#rst-primer",
> - "title": "reStructuredText Primer"
> - },
> - "rst-inline-markup": {
> - "link": "/docs/reStructuredText-primer.html#rst-inline-markup",
> - "title": "Inline markup"
> - },
> - "rst-literal-blocks": {
> - "link": "/docs/reStructuredText-primer.html#rst-literal-blocks",
> - "title": "Literal blocks"
> - },
> - "rst-doctest-blocks": {
> - "link": "/docs/reStructuredText-primer.html#rst-doctest-blocks",
> - "title": "Doctest blocks"
> - },
> - "rst-tables": {
> - "link": "/docs/reStructuredText-primer.html#rst-tables",
> - "title": "Tables"
> - },
> - "rst-field-lists": {
> - "link": "/docs/reStructuredText-primer.html#rst-field-lists",
> - "title": "Field Lists"
> - },
> - "rst-roles-alt": {
> - "link": "/docs/reStructuredText-primer.html#rst-roles-alt",
> - "title": "Roles"
> - },
> - "rst-directives": {
> - "link": "/docs/reStructuredText-primer.html#rst-directives",
> - "title": "Directives"
> - },
> - "html-meta": {
> - "link": "/docs/reStructuredText-primer.html#html-meta",
> - "title": "HTML Metadata"
> - },
> "storage-disk-management": {
> "link": "/docs/storage.html#storage-disk-management",
> "title": "Disk Management"
> @@ -123,6 +87,10 @@ const proxmoxOnlineHelpInfo = {
> "link": "/docs/storage.html#storage-datastore-create",
> "title": "Creating a Datastore"
> },
> + "sysadmin-host-administration": {
> + "link": "/docs/sysadmin.html#sysadmin-host-administration",
> + "title": "Host System Administration"
> + },
> "user-mgmt": {
> "link": "/docs/user-management.html#user-mgmt",
> "title": "User Management"
>
next prev parent reply other threads:[~2020-11-10 12:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 12:38 [pbs-devel] [PATCH proxmox-backup 1/3] docs: add ref for sysadmin host admin section Aaron Lauterer
2020-11-10 12:38 ` [pbs-devel] [PATCH proxmox-backup 2/3] ui: onlinehelp update with sysadmin_host_administration Aaron Lauterer
2020-11-10 12:53 ` Thomas Lamprecht [this message]
2020-11-10 13:15 ` Aaron Lauterer
2020-11-10 13:40 ` Thomas Lamprecht
2020-11-10 12:38 ` [pbs-devel] [PATCH proxmox-backup 3/3] ui: add mising panel help buttons Aaron Lauterer
2020-11-10 13:10 ` [pbs-devel] applied: " Thomas Lamprecht
2020-11-10 13:10 ` [pbs-devel] applied: [PATCH proxmox-backup 1/3] docs: add ref for sysadmin host admin section Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d5c6c92-ff04-ece6-9662-cbc3939d3d16@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=a.lauterer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox