Re: [pbs-devel] [PATCH proxmox-backup 0/5] add context menu to datastore content

[Max Carrara <m.carrara@proxmox.com>]

On 11/28/23 10:43, Dominik Csapak wrote:
> and add a 'show information' window that includes the upload statistics.
> This also moves some actions from the column directly into a 'hamburger
> menu' so we don't overload the grid.
> 
> The only downside to this currently is that i could get keyboard
> navigation to work for the context menu or the hamburger menu, but i'm
> still looking into this.
> 
> This series replaces my old one for the upload statistics [0]

Tested it as well - looks pretty good! Works as described.

The code also seems rather straightforward; I cannot comment too much on
the JS side of things, but all in all there's nothing I could complain
about.

Tested-by: Max Carrara <m.carrara@proxmox.com>
Reviewed-by: Max Carrara <m.carrara@proxmox.com>

> 
> 
> 0: https://lists.proxmox.com/pipermail/pbs-devel/2023-August/006343.html
> 
> Dominik Csapak (5):
>   api-types: add an UploadStatistic api type
>   api: datastore admin: add 'snapshot-information' api call
>   ui: datastore content: add context menu to groups and snapshots
>   ui: datastore content: add snapshot information to context menu
>   ui: datastore content: add 'more actions' menu to actions
> 
>  pbs-api-types/src/datastore.rs |  36 +++++++
>  src/api2/admin/datastore.rs    | 117 +++++++++++++++++++--
>  www/Makefile                   |   1 +
>  www/datastore/Content.js       | 174 +++++++++++++++++++++++++++----
>  www/window/SnapshotInfo.js     | 182 +++++++++++++++++++++++++++++++++
>  5 files changed, 486 insertions(+), 24 deletions(-)
>  create mode 100644 www/window/SnapshotInfo.js
>