* [pbs-devel] [PATCH proxmox-backup] ui: add 'keep configs' checkbox to datastore removal window
@ 2023-11-29 8:59 Dominik Csapak
2023-11-29 9:36 ` [pbs-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2023-11-29 8:59 UTC (permalink / raw)
To: pbs-devel
From: Hannes Laimer <h.laimer@proxmox.com>
... since the API already accepts a boolean for that.
Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
[ DC: actually send the option to the api ]
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
resent the old patch from hannes but added code to make it work,
hope thats ok @hannes
www/datastore/OptionView.js | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/www/datastore/OptionView.js b/www/datastore/OptionView.js
index 448cd4b3..3ef4d3d5 100644
--- a/www/datastore/OptionView.js
+++ b/www/datastore/OptionView.js
@@ -34,7 +34,10 @@ Ext.define('PBS.window.SafeDatastoreDestroy', {
getParams: function() {
let viewModel = this.getViewModel();
- let params = { 'destroy-data': viewModel.get('destroyData') };
+ let params = {
+ 'destroy-data': viewModel.get('destroyData'),
+ 'keep-job-configs': viewModel.get('keepJobConfigs'),
+ };
return `?${Ext.Object.toQueryString(params)}`;
},
additionalItems: [{
@@ -45,6 +48,14 @@ Ext.define('PBS.window.SafeDatastoreDestroy', {
bind: {
value: '{destroyData}',
},
+ }, {
+ xtype: 'proxmoxcheckbox',
+ name: 'keep-job-configs',
+ boxLabel: gettext("Keep configured jobs and permissions"),
+ defaultValue: false,
+ bind: {
+ value: '{keepJobConfigs}',
+ },
}, {
xtype: 'component',
reference: 'noteCmp',
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pbs-devel] applied: [PATCH proxmox-backup] ui: add 'keep configs' checkbox to datastore removal window
2023-11-29 8:59 [pbs-devel] [PATCH proxmox-backup] ui: add 'keep configs' checkbox to datastore removal window Dominik Csapak
@ 2023-11-29 9:36 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2023-11-29 9:36 UTC (permalink / raw)
To: Proxmox Backup Server development discussion, Dominik Csapak
Am 29/11/2023 um 09:59 schrieb Dominik Csapak:
> From: Hannes Laimer <h.laimer@proxmox.com>
>
> ... since the API already accepts a boolean for that.
>
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> [ DC: actually send the option to the api ]
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> resent the old patch from hannes but added code to make it work,
> hope thats ok @hannes
>
> www/datastore/OptionView.js | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-29 9:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-29 8:59 [pbs-devel] [PATCH proxmox-backup] ui: add 'keep configs' checkbox to datastore removal window Dominik Csapak
2023-11-29 9:36 ` [pbs-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox