From: Folke Gleumes <f.gleumes@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH widget-toolkit/proxmox-backup v3 0/9] Fix #3115: VLAN Network Interface Configuration
Date: Thu, 18 Apr 2024 12:04:50 +0200 [thread overview]
Message-ID: <495e888a91aa9032c5953e87c23174c0a3ca9e3e.camel@proxmox.com> (raw)
In-Reply-To: <e009ee0ca26acdfc522201a50dd75c6709139bc4.camel@proxmox.com>
As I just discovered that this bug is also present in PVE and its just
a small visual inconsistency, I don't think its a blocker.
On Thu, 2024-04-18 at 11:43 +0200, Folke Gleumes wrote:
> Found a small ui bug in the vlan dialog: When the advanced checkbox
> is
> not active, the first few pixel rows of the upper left input box are
> cut off.
>
> When the ui is fixed, you can consider this:
>
> Tested-by: Folke Gleumes <f.gleumes@proxmox.com>
>
> On Thu, 2024-04-04 at 12:00 +0200, Stefan Lendl wrote:
> > This patch series allows configuring a VLAN network interfaces in
> > the
> > PBS GUI
> >
> > * Added reading and writing of VLAN network config.
> > * Created and updating of VLAN network interfaces via the API.
> > * Copied the VLAN field widget from PVE and enabled the Linux VLAN
> > interface
> > type in the GUI.
> > * Unit tests for reading and writing the network config.
> > * Some cleanup to leave touched functions cleaner than before.
> >
> > Changes v2 -> v3:
> > * slightly updated commit messages and changed typo in git trailer
> >
> > Changes v1 -> v2:
> > * Adapted parameter handling to not expect all properties to be set
> > * Incorporated style suggestions
> >
> > widget-toolkit:
> >
> > Stefan Lendl (1):
> > form: include vlan field widget from PVE
> >
> > src/Makefile | 1 +
> > src/form/VlanField.js | 40
> > ++++++++++++++++++++++++++++++++++++++++
> > src/node/NetworkEdit.js | 6 +++---
> > 3 files changed, 44 insertions(+), 3 deletions(-)
> > create mode 100644 src/form/VlanField.js
> >
> >
> > proxmox-backup:
> >
> > Stefan Lendl (8):
> > tests: move network tests to parser.rs
> > tests: simple tests for writing the network config
> > config: write vlan network interface
> > config: parse vlan interface from config
> > config: remove unnecessary pub in various methods in
> > NetworkConfig
> > fmt: fix intendation in api macro
> > api: create and update vlan interfaces
> > ui: enable vlan widget
> >
> > pbs-api-types/src/network.rs | 17 ++
> > pbs-config/src/network/lexer.rs | 6 +
> > pbs-config/src/network/mod.rs | 300 +++++++++++++++++----------
> > --
> > --
> > pbs-config/src/network/parser.rs | 249 ++++++++++++++++++++++++-
> > src/api2/node/network.rs | 72 +++++++-
> > www/SystemConfiguration.js | 2 +-
> > 6 files changed, 504 insertions(+), 142 deletions(-)
> >
> >
> > Summary over all repositories:
> > 9 files changed, 548 insertions(+), 0 deletions(-)
> >
>
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-04-18 10:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-04 10:00 Stefan Lendl
2024-04-04 10:00 ` [pbs-devel] [PATCH widget-toolkit v3 1/9] form: include vlan field widget from PVE Stefan Lendl
2024-04-04 10:00 ` [pbs-devel] [PATCH proxmox-backup v3 2/9] tests: move network tests to parser.rs Stefan Lendl
2024-04-04 10:00 ` [pbs-devel] [PATCH proxmox-backup v3 3/9] tests: simple tests for writing the network config Stefan Lendl
2024-04-04 10:00 ` [pbs-devel] [PATCH proxmox-backup v3 4/9] config: write vlan network interface Stefan Lendl
2024-04-04 10:00 ` [pbs-devel] [PATCH proxmox-backup v3 5/9] config: parse vlan interface from config Stefan Lendl
2024-04-04 10:00 ` [pbs-devel] [PATCH proxmox-backup v3 6/9] config: remove unnecessary pub in various methods in NetworkConfig Stefan Lendl
2024-04-04 10:00 ` [pbs-devel] [PATCH proxmox-backup v3 7/9] fmt: fix intendation in api macro Stefan Lendl
2024-04-04 10:00 ` [pbs-devel] [PATCH proxmox-backup v3 8/9] api: create and update vlan interfaces Stefan Lendl
2024-04-04 10:00 ` [pbs-devel] [PATCH proxmox-backup v3 9/9] ui: enable vlan widget Stefan Lendl
2024-04-18 9:43 ` [pbs-devel] [PATCH widget-toolkit/proxmox-backup v3 0/9] Fix #3115: VLAN Network Interface Configuration Folke Gleumes
2024-04-18 10:04 ` Folke Gleumes [this message]
2024-04-24 19:53 ` [pbs-devel] applied-series: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=495e888a91aa9032c5953e87c23174c0a3ca9e3e.camel@proxmox.com \
--to=f.gleumes@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox