* [pbs-devel] [PATCH proxmox-backup] api: admin: add Datastore.Modify permission for mount
@ 2024-11-27 10:18 Hannes Laimer
2024-11-27 10:49 ` [pbs-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Hannes Laimer @ 2024-11-27 10:18 UTC (permalink / raw)
To: pbs-devel
So the mount and unmount endpoint have matching permissions.
Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
src/api2/admin/datastore.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/api2/admin/datastore.rs b/src/api2/admin/datastore.rs
index cae7eb89c..d27c00f2b 100644
--- a/src/api2/admin/datastore.rs
+++ b/src/api2/admin/datastore.rs
@@ -2513,7 +2513,7 @@ pub fn do_mount_device(datastore: DataStoreConfig) -> Result<(), Error> {
},
access: {
permission: &Permission::And(&[
- &Permission::Privilege(&["datastore", "{store}"], PRIV_DATASTORE_AUDIT, false),
+ &Permission::Privilege(&["datastore", "{store}"], PRIV_DATASTORE_MODIFY, false),
&Permission::Privilege(&["system", "disks"], PRIV_SYS_MODIFY, false)
]),
},
--
2.39.5
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pbs-devel] applied: [PATCH proxmox-backup] api: admin: add Datastore.Modify permission for mount
2024-11-27 10:18 [pbs-devel] [PATCH proxmox-backup] api: admin: add Datastore.Modify permission for mount Hannes Laimer
@ 2024-11-27 10:49 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2024-11-27 10:49 UTC (permalink / raw)
To: Proxmox Backup Server development discussion, Hannes Laimer
Am 27.11.24 um 11:18 schrieb Hannes Laimer:
> So the mount and unmount endpoint have matching permissions.
>
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
> src/api2/admin/datastore.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-11-27 10:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-27 10:18 [pbs-devel] [PATCH proxmox-backup] api: admin: add Datastore.Modify permission for mount Hannes Laimer
2024-11-27 10:49 ` [pbs-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox