[pbs-devel] [PATCH proxmox-backup 1/2] ui: NavigationTree: do not modify list while iterating

[pbs-devel] [PATCH proxmox-backup 1/2] ui: NavigationTree: do not modify list while iterating

[Dominik Csapak]

iterating over a nodeinterfaces children while removing them
will lead to 'child' being undefined

instead collect the children to remove in a separate list
and iterate over them

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/NavigationTree.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/www/NavigationTree.js b/www/NavigationTree.js
index a9e97567..4bdfbc66 100644
--- a/www/NavigationTree.js
+++ b/www/NavigationTree.js
@@ -188,11 +188,13 @@ Ext.define('PBS.view.main.NavigationTree', {
 		}
 	    }
 
+	    let toremove = [];
 	    list.eachChild((child) => {
 		if (!newSet[child.data.path]) {
-		    list.removeChild(child, true);
+		    toremove.push(child);
 		}
 	    });
+	    toremove.forEach((child) => list.removeChild(child, true));
 
 	    if (view.pathToSelect !== undefined) {
 		let path = view.pathToSelect;
-- 
2.20.1

[pbs-devel] [PATCH proxmox-backup 2/2] ui: tape: increase tapestore interval

[Dominik Csapak]

from 2 to 60 seconds. To retain the response time of the gui
when adding/editing/removing, trigger a manual reload on these actions

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/NavigationTree.js     | 11 ++++++++++-
 www/tape/ChangerConfig.js |  6 ++++++
 www/tape/DriveConfig.js   |  6 ++++++
 3 files changed, 22 insertions(+), 1 deletion(-)

diff --git a/www/NavigationTree.js b/www/NavigationTree.js
index 4bdfbc66..6d288f09 100644
--- a/www/NavigationTree.js
+++ b/www/NavigationTree.js
@@ -122,7 +122,7 @@ Ext.define('PBS.view.main.NavigationTree', {
 		if (view.tapestore === undefined) {
 		    view.tapestore = Ext.create('Proxmox.data.UpdateStore', {
 			autoStart: true,
-			interval: 2 * 1000,
+			interval: 60 * 1000,
 			storeid: 'pbs-tape-drive-list',
 			model: 'pbs-tape-drive-list',
 		    });
@@ -269,6 +269,15 @@ Ext.define('PBS.view.main.NavigationTree', {
 	},
     },
 
+    reloadTapeStore: function() {
+	let me = this;
+	if (!PBS.enableTapeUI) {
+	    return;
+	}
+
+	me.tapestore.load();
+    },
+
     select: function(path, silent) {
 	var me = this;
 	if (me.rstore.isLoaded() && (!PBS.enableTapeUI || me.tapestore.isLoaded())) {
diff --git a/www/tape/ChangerConfig.js b/www/tape/ChangerConfig.js
index 1646ddef..1c048b23 100644
--- a/www/tape/ChangerConfig.js
+++ b/www/tape/ChangerConfig.js
@@ -11,6 +11,11 @@ Ext.define('PBS.TapeManagement.ChangerPanel', {
     controller: {
 	xclass: 'Ext.app.ViewController',
 
+	reloadTapeStore: function() {
+	    let navtree = Ext.ComponentQuery.query('navigationtree')[0];
+	    navtree.reloadTapeStore();
+	},
+
 	onAdd: function() {
 	    let me = this;
 	    Ext.create('PBS.TapeManagement.ChangerEditWindow', {
@@ -40,6 +45,7 @@ Ext.define('PBS.TapeManagement.ChangerPanel', {
 
 	reload: function() {
 	    this.getView().getStore().rstore.load();
+	    this.reloadTapeStore();
 	},
 
 	stopStore: function() {
diff --git a/www/tape/DriveConfig.js b/www/tape/DriveConfig.js
index 763f8e55..40d4b2a9 100644
--- a/www/tape/DriveConfig.js
+++ b/www/tape/DriveConfig.js
@@ -19,6 +19,11 @@ Ext.define('PBS.TapeManagement.DrivePanel', {
     controller: {
 	xclass: 'Ext.app.ViewController',
 
+	reloadTapeStore: function() {
+	    let navtree = Ext.ComponentQuery.query('navigationtree')[0];
+	    navtree.reloadTapeStore();
+	},
+
 	onAdd: function() {
 	    let me = this;
 	    Ext.create('PBS.TapeManagement.DriveEditWindow', {
@@ -57,6 +62,7 @@ Ext.define('PBS.TapeManagement.DrivePanel', {
 
 	reload: function() {
 	    this.getView().getStore().rstore.load();
+	    this.reloadTapeStore();
 	},
 
 	stopStore: function() {
-- 
2.20.1

Re: [pbs-devel] [PATCH proxmox-backup 2/2] ui: tape: increase tapestore interval

[Thomas Lamprecht]

On 10.03.21 10:10, Dominik Csapak wrote:
> from 2 to 60 seconds. To retain the response time of the gui
> when adding/editing/removing, trigger a manual reload on these actions
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>

Please add my Suggested-by or Reported-by tags for reference the next time,
thanks!

> ---
>  www/NavigationTree.js     | 11 ++++++++++-
>  www/tape/ChangerConfig.js |  6 ++++++
>  www/tape/DriveConfig.js   |  6 ++++++
>  3 files changed, 22 insertions(+), 1 deletion(-)
> 
> diff --git a/www/NavigationTree.js b/www/NavigationTree.js
> index 4bdfbc66..6d288f09 100644
> --- a/www/NavigationTree.js
> +++ b/www/NavigationTree.js
> @@ -122,7 +122,7 @@ Ext.define('PBS.view.main.NavigationTree', {
>  		if (view.tapestore === undefined) {
>  		    view.tapestore = Ext.create('Proxmox.data.UpdateStore', {
>  			autoStart: true,
> -			interval: 2 * 1000,
> +			interval: 60 * 1000,
>  			storeid: 'pbs-tape-drive-list',
>  			model: 'pbs-tape-drive-list',
>  		    });
> @@ -269,6 +269,15 @@ Ext.define('PBS.view.main.NavigationTree', {
>  	},
>      },
>  
> +    reloadTapeStore: function() {
> +	let me = this;
> +	if (!PBS.enableTapeUI) {
> +	    return;
> +	}
> +
> +	me.tapestore.load();
> +    },
> +
>      select: function(path, silent) {
>  	var me = this;
>  	if (me.rstore.isLoaded() && (!PBS.enableTapeUI || me.tapestore.isLoaded())) {
> diff --git a/www/tape/ChangerConfig.js b/www/tape/ChangerConfig.js
> index 1646ddef..1c048b23 100644
> --- a/www/tape/ChangerConfig.js
> +++ b/www/tape/ChangerConfig.js
> @@ -11,6 +11,11 @@ Ext.define('PBS.TapeManagement.ChangerPanel', {
>      controller: {
>  	xclass: 'Ext.app.ViewController',
>  
> +	reloadTapeStore: function() {
> +	    let navtree = Ext.ComponentQuery.query('navigationtree')[0];
> +	    navtree.reloadTapeStore();
> +	},
> +
>  	onAdd: function() {
>  	    let me = this;
>  	    Ext.create('PBS.TapeManagement.ChangerEditWindow', {
> @@ -40,6 +45,7 @@ Ext.define('PBS.TapeManagement.ChangerPanel', {
>  
>  	reload: function() {
>  	    this.getView().getStore().rstore.load();
> +	    this.reloadTapeStore();
>  	},
>  
>  	stopStore: function() {
> diff --git a/www/tape/DriveConfig.js b/www/tape/DriveConfig.js
> index 763f8e55..40d4b2a9 100644
> --- a/www/tape/DriveConfig.js
> +++ b/www/tape/DriveConfig.js
> @@ -19,6 +19,11 @@ Ext.define('PBS.TapeManagement.DrivePanel', {
>      controller: {
>  	xclass: 'Ext.app.ViewController',
>  
> +	reloadTapeStore: function() {
> +	    let navtree = Ext.ComponentQuery.query('navigationtree')[0];
> +	    navtree.reloadTapeStore();
> +	},
> +
>  	onAdd: function() {
>  	    let me = this;
>  	    Ext.create('PBS.TapeManagement.DriveEditWindow', {
> @@ -57,6 +62,7 @@ Ext.define('PBS.TapeManagement.DrivePanel', {
>  
>  	reload: function() {
>  	    this.getView().getStore().rstore.load();
> +	    this.reloadTapeStore();
>  	},
>  
>  	stopStore: function() {
> 

Re: [pbs-devel] [PATCH proxmox-backup 2/2] ui: tape: increase tapestore interval

[Dominik Csapak]

On 3/10/21 12:19 PM, Thomas Lamprecht wrote:
> On 10.03.21 10:10, Dominik Csapak wrote:
>> from 2 to 60 seconds. To retain the response time of the gui
>> when adding/editing/removing, trigger a manual reload on these actions
>>
>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> 
> Please add my Suggested-by or Reported-by tags for reference the next time,
> thanks!
> 

yes of course, sorry

>> ---
>>   www/NavigationTree.js     | 11 ++++++++++-
>>   www/tape/ChangerConfig.js |  6 ++++++
>>   www/tape/DriveConfig.js   |  6 ++++++
>>   3 files changed, 22 insertions(+), 1 deletion(-)
>>
>> diff --git a/www/NavigationTree.js b/www/NavigationTree.js
>> index 4bdfbc66..6d288f09 100644
>> --- a/www/NavigationTree.js
>> +++ b/www/NavigationTree.js
>> @@ -122,7 +122,7 @@ Ext.define('PBS.view.main.NavigationTree', {
>>   		if (view.tapestore === undefined) {
>>   		    view.tapestore = Ext.create('Proxmox.data.UpdateStore', {
>>   			autoStart: true,
>> -			interval: 2 * 1000,
>> +			interval: 60 * 1000,
>>   			storeid: 'pbs-tape-drive-list',
>>   			model: 'pbs-tape-drive-list',
>>   		    });
>> @@ -269,6 +269,15 @@ Ext.define('PBS.view.main.NavigationTree', {
>>   	},
>>       },
>>   
>> +    reloadTapeStore: function() {
>> +	let me = this;
>> +	if (!PBS.enableTapeUI) {
>> +	    return;
>> +	}
>> +
>> +	me.tapestore.load();
>> +    },
>> +
>>       select: function(path, silent) {
>>   	var me = this;
>>   	if (me.rstore.isLoaded() && (!PBS.enableTapeUI || me.tapestore.isLoaded())) {
>> diff --git a/www/tape/ChangerConfig.js b/www/tape/ChangerConfig.js
>> index 1646ddef..1c048b23 100644
>> --- a/www/tape/ChangerConfig.js
>> +++ b/www/tape/ChangerConfig.js
>> @@ -11,6 +11,11 @@ Ext.define('PBS.TapeManagement.ChangerPanel', {
>>       controller: {
>>   	xclass: 'Ext.app.ViewController',
>>   
>> +	reloadTapeStore: function() {
>> +	    let navtree = Ext.ComponentQuery.query('navigationtree')[0];
>> +	    navtree.reloadTapeStore();
>> +	},
>> +
>>   	onAdd: function() {
>>   	    let me = this;
>>   	    Ext.create('PBS.TapeManagement.ChangerEditWindow', {
>> @@ -40,6 +45,7 @@ Ext.define('PBS.TapeManagement.ChangerPanel', {
>>   
>>   	reload: function() {
>>   	    this.getView().getStore().rstore.load();
>> +	    this.reloadTapeStore();
>>   	},
>>   
>>   	stopStore: function() {
>> diff --git a/www/tape/DriveConfig.js b/www/tape/DriveConfig.js
>> index 763f8e55..40d4b2a9 100644
>> --- a/www/tape/DriveConfig.js
>> +++ b/www/tape/DriveConfig.js
>> @@ -19,6 +19,11 @@ Ext.define('PBS.TapeManagement.DrivePanel', {
>>       controller: {
>>   	xclass: 'Ext.app.ViewController',
>>   
>> +	reloadTapeStore: function() {
>> +	    let navtree = Ext.ComponentQuery.query('navigationtree')[0];
>> +	    navtree.reloadTapeStore();
>> +	},
>> +
>>   	onAdd: function() {
>>   	    let me = this;
>>   	    Ext.create('PBS.TapeManagement.DriveEditWindow', {
>> @@ -57,6 +62,7 @@ Ext.define('PBS.TapeManagement.DrivePanel', {
>>   
>>   	reload: function() {
>>   	    this.getView().getStore().rstore.load();
>> +	    this.reloadTapeStore();
>>   	},
>>   
>>   	stopStore: function() {
>>
> 

Re: [pbs-devel] [PATCH proxmox-backup 2/2] ui: tape: increase tapestore interval

[Thomas Lamprecht]

On 10.03.21 12:38, Dominik Csapak wrote:
> 
> 
> On 3/10/21 12:19 PM, Thomas Lamprecht wrote:
>> On 10.03.21 10:10, Dominik Csapak wrote:
>>> from 2 to 60 seconds. To retain the response time of the gui
>>> when adding/editing/removing, trigger a manual reload on these actions
>>>
>>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>>
>> Please add my Suggested-by or Reported-by tags for reference the next time,
>> thanks!
>>
> 
> yes of course, sorry

Thanks!

btw. can you please freshen up my brain on the storeid config from UpdateStore?
As its not used there directly and it's base class Ext.data.Store only knows
about storeId [0] (note the casing difference), and using that one would actually
register the store to the Ext.data.StoreManager [1] and we could avoid the detour
over querying the nav tree but do a 

Ext.data.StoreManager.lookup('pbs-tape-drive-list').load();

instead. Not sure about any extra cost of that manager, but code wise it would
be quite less (and only called from places where we know that PBS.enableTapeUI
is true already).

And if the UpdateStores `storeid` property is only a "copy-is-my-hobby" left
over, or really misspelled then I'd maybe drop it or fix spelling, respectively.

[0]: https://docs.sencha.com/extjs/6.0.1/classic/Ext.data.Store.html#cfg-storeId
[1]: https://docs.sencha.com/extjs/6.0.1/classic/Ext.data.StoreManager.html

> 
>>> ---
>>>   www/NavigationTree.js     | 11 ++++++++++-
>>>   www/tape/ChangerConfig.js |  6 ++++++
>>>   www/tape/DriveConfig.js   |  6 ++++++
>>>   3 files changed, 22 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/www/NavigationTree.js b/www/NavigationTree.js
>>> index 4bdfbc66..6d288f09 100644
>>> --- a/www/NavigationTree.js
>>> +++ b/www/NavigationTree.js
>>> @@ -122,7 +122,7 @@ Ext.define('PBS.view.main.NavigationTree', {
>>>           if (view.tapestore === undefined) {
>>>               view.tapestore = Ext.create('Proxmox.data.UpdateStore', {
>>>               autoStart: true,
>>> -            interval: 2 * 1000,
>>> +            interval: 60 * 1000,
>>>               storeid: 'pbs-tape-drive-list',
>>>               model: 'pbs-tape-drive-list',
>>>               });
>>> @@ -269,6 +269,15 @@ Ext.define('PBS.view.main.NavigationTree', {
>>>       },
>>>       },
>>>   +    reloadTapeStore: function() {
>>> +    let me = this;
>>> +    if (!PBS.enableTapeUI) {
>>> +        return;
>>> +    }
>>> +
>>> +    me.tapestore.load();
>>> +    },
>>> +
>>>       select: function(path, silent) {
>>>       var me = this;
>>>       if (me.rstore.isLoaded() && (!PBS.enableTapeUI || me.tapestore.isLoaded())) {
>>> diff --git a/www/tape/ChangerConfig.js b/www/tape/ChangerConfig.js
>>> index 1646ddef..1c048b23 100644
>>> --- a/www/tape/ChangerConfig.js
>>> +++ b/www/tape/ChangerConfig.js
>>> @@ -11,6 +11,11 @@ Ext.define('PBS.TapeManagement.ChangerPanel', {
>>>       controller: {
>>>       xclass: 'Ext.app.ViewController',
>>>   +    reloadTapeStore: function() {
>>> +        let navtree = Ext.ComponentQuery.query('navigationtree')[0];
>>> +        navtree.reloadTapeStore();
>>> +    },
>>> +
>>>       onAdd: function() {
>>>           let me = this;
>>>           Ext.create('PBS.TapeManagement.ChangerEditWindow', {
>>> @@ -40,6 +45,7 @@ Ext.define('PBS.TapeManagement.ChangerPanel', {
>>>         reload: function() {
>>>           this.getView().getStore().rstore.load();
>>> +        this.reloadTapeStore();
>>>       },
>>>         stopStore: function() {
>>> diff --git a/www/tape/DriveConfig.js b/www/tape/DriveConfig.js
>>> index 763f8e55..40d4b2a9 100644
>>> --- a/www/tape/DriveConfig.js
>>> +++ b/www/tape/DriveConfig.js
>>> @@ -19,6 +19,11 @@ Ext.define('PBS.TapeManagement.DrivePanel', {
>>>       controller: {
>>>       xclass: 'Ext.app.ViewController',
>>>   +    reloadTapeStore: function() {
>>> +        let navtree = Ext.ComponentQuery.query('navigationtree')[0];
>>> +        navtree.reloadTapeStore();
>>> +    },
>>> +
>>>       onAdd: function() {
>>>           let me = this;
>>>           Ext.create('PBS.TapeManagement.DriveEditWindow', {
>>> @@ -57,6 +62,7 @@ Ext.define('PBS.TapeManagement.DrivePanel', {
>>>         reload: function() {
>>>           this.getView().getStore().rstore.load();
>>> +        this.reloadTapeStore();
>>>       },
>>>         stopStore: function() {
>>>
>>

Re: [pbs-devel] [PATCH proxmox-backup 2/2] ui: tape: increase tapestore interval

[Dominik Csapak]

On 3/10/21 12:47 PM, Thomas Lamprecht wrote:
> On 10.03.21 12:38, Dominik Csapak wrote:
>>
>>
>> On 3/10/21 12:19 PM, Thomas Lamprecht wrote:
>>> On 10.03.21 10:10, Dominik Csapak wrote:
>>>> from 2 to 60 seconds. To retain the response time of the gui
>>>> when adding/editing/removing, trigger a manual reload on these actions
>>>>
>>>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>>>
>>> Please add my Suggested-by or Reported-by tags for reference the next time,
>>> thanks!
>>>
>>
>> yes of course, sorry
> 
> Thanks!
> 
> btw. can you please freshen up my brain on the storeid config from UpdateStore?
> As its not used there directly and it's base class Ext.data.Store only knows
> about storeId [0] (note the casing difference), and using that one would actually
> register the store to the Ext.data.StoreManager [1] and we could avoid the detour
> over querying the nav tree but do a
> 
> Ext.data.StoreManager.lookup('pbs-tape-drive-list').load();
> 
> instead. Not sure about any extra cost of that manager, but code wise it would
> be quite less (and only called from places where we know that PBS.enableTapeUI
> is true already).
> 
> And if the UpdateStores `storeid` property is only a "copy-is-my-hobby" left
> over, or really misspelled then I'd maybe drop it or fix spelling, respectively.
> 
> [0]: https://docs.sencha.com/extjs/6.0.1/classic/Ext.data.Store.html#cfg-storeId
> [1]: https://docs.sencha.com/extjs/6.0.1/classic/Ext.data.StoreManager.html

mhmm after taking a short look at it, we require 'storeid' in the 
UpdateStore, otherwise it fails with an exception. But i cannot find
any actual use for that, so i assume it was meant to be storeId in the
first place but we never noticed

i'll check if changing it to storeId has any negative side-effects
(such as leftover stores after some panel gets destroyed) and would
send patches to change all occurrences to storeId

if it's too costly (or has other issues) i'd prepare patches to
drop it from the UpdateStore altogether (since we do not
seem to use it)

> 
>>
>>>> ---
>>>>    www/NavigationTree.js     | 11 ++++++++++-
>>>>    www/tape/ChangerConfig.js |  6 ++++++
>>>>    www/tape/DriveConfig.js   |  6 ++++++
>>>>    3 files changed, 22 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/www/NavigationTree.js b/www/NavigationTree.js
>>>> index 4bdfbc66..6d288f09 100644
>>>> --- a/www/NavigationTree.js
>>>> +++ b/www/NavigationTree.js
>>>> @@ -122,7 +122,7 @@ Ext.define('PBS.view.main.NavigationTree', {
>>>>            if (view.tapestore === undefined) {
>>>>                view.tapestore = Ext.create('Proxmox.data.UpdateStore', {
>>>>                autoStart: true,
>>>> -            interval: 2 * 1000,
>>>> +            interval: 60 * 1000,
>>>>                storeid: 'pbs-tape-drive-list',
>>>>                model: 'pbs-tape-drive-list',
>>>>                });
>>>> @@ -269,6 +269,15 @@ Ext.define('PBS.view.main.NavigationTree', {
>>>>        },
>>>>        },
>>>>    +    reloadTapeStore: function() {
>>>> +    let me = this;
>>>> +    if (!PBS.enableTapeUI) {
>>>> +        return;
>>>> +    }
>>>> +
>>>> +    me.tapestore.load();
>>>> +    },
>>>> +
>>>>        select: function(path, silent) {
>>>>        var me = this;
>>>>        if (me.rstore.isLoaded() && (!PBS.enableTapeUI || me.tapestore.isLoaded())) {
>>>> diff --git a/www/tape/ChangerConfig.js b/www/tape/ChangerConfig.js
>>>> index 1646ddef..1c048b23 100644
>>>> --- a/www/tape/ChangerConfig.js
>>>> +++ b/www/tape/ChangerConfig.js
>>>> @@ -11,6 +11,11 @@ Ext.define('PBS.TapeManagement.ChangerPanel', {
>>>>        controller: {
>>>>        xclass: 'Ext.app.ViewController',
>>>>    +    reloadTapeStore: function() {
>>>> +        let navtree = Ext.ComponentQuery.query('navigationtree')[0];
>>>> +        navtree.reloadTapeStore();
>>>> +    },
>>>> +
>>>>        onAdd: function() {
>>>>            let me = this;
>>>>            Ext.create('PBS.TapeManagement.ChangerEditWindow', {
>>>> @@ -40,6 +45,7 @@ Ext.define('PBS.TapeManagement.ChangerPanel', {
>>>>          reload: function() {
>>>>            this.getView().getStore().rstore.load();
>>>> +        this.reloadTapeStore();
>>>>        },
>>>>          stopStore: function() {
>>>> diff --git a/www/tape/DriveConfig.js b/www/tape/DriveConfig.js
>>>> index 763f8e55..40d4b2a9 100644
>>>> --- a/www/tape/DriveConfig.js
>>>> +++ b/www/tape/DriveConfig.js
>>>> @@ -19,6 +19,11 @@ Ext.define('PBS.TapeManagement.DrivePanel', {
>>>>        controller: {
>>>>        xclass: 'Ext.app.ViewController',
>>>>    +    reloadTapeStore: function() {
>>>> +        let navtree = Ext.ComponentQuery.query('navigationtree')[0];
>>>> +        navtree.reloadTapeStore();
>>>> +    },
>>>> +
>>>>        onAdd: function() {
>>>>            let me = this;
>>>>            Ext.create('PBS.TapeManagement.DriveEditWindow', {
>>>> @@ -57,6 +62,7 @@ Ext.define('PBS.TapeManagement.DrivePanel', {
>>>>          reload: function() {
>>>>            this.getView().getStore().rstore.load();
>>>> +        this.reloadTapeStore();
>>>>        },
>>>>          stopStore: function() {
>>>>
>>>
> 

Re: [pbs-devel] [PATCH proxmox-backup 2/2] ui: tape: increase tapestore interval

[Thomas Lamprecht]

On 10.03.21 13:32, Dominik Csapak wrote:
> On 3/10/21 12:47 PM, Thomas Lamprecht wrote:
>> On 10.03.21 12:38, Dominik Csapak wrote:
>>>
>>>
>>> On 3/10/21 12:19 PM, Thomas Lamprecht wrote:
>>>> On 10.03.21 10:10, Dominik Csapak wrote:
>>>>> from 2 to 60 seconds. To retain the response time of the gui
>>>>> when adding/editing/removing, trigger a manual reload on these actions
>>>>>
>>>>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>>>>
>>>> Please add my Suggested-by or Reported-by tags for reference the next time,
>>>> thanks!
>>>>
>>>
>>> yes of course, sorry
>>
>> Thanks!
>>
>> btw. can you please freshen up my brain on the storeid config from UpdateStore?
>> As its not used there directly and it's base class Ext.data.Store only knows
>> about storeId [0] (note the casing difference), and using that one would actually
>> register the store to the Ext.data.StoreManager [1] and we could avoid the detour
>> over querying the nav tree but do a
>>
>> Ext.data.StoreManager.lookup('pbs-tape-drive-list').load();
>>
>> instead. Not sure about any extra cost of that manager, but code wise it would
>> be quite less (and only called from places where we know that PBS.enableTapeUI
>> is true already).
>>
>> And if the UpdateStores `storeid` property is only a "copy-is-my-hobby" left
>> over, or really misspelled then I'd maybe drop it or fix spelling, respectively.
>>
>> [0]: https://docs.sencha.com/extjs/6.0.1/classic/Ext.data.Store.html#cfg-storeId
>> [1]: https://docs.sencha.com/extjs/6.0.1/classic/Ext.data.StoreManager.html
> 
> mhmm after taking a short look at it, we require 'storeid' in the UpdateStore, otherwise it fails with an exception. But i cannot find
> any actual use for that, so i assume it was meant to be storeId in the
> first place but we never noticed

yeah so same findings I had.

> 
> i'll check if changing it to storeId has any negative side-effects
> (such as leftover stores after some panel gets destroyed) and would
> send patches to change all occurrences to storeId
> 
> if it's too costly (or has other issues) i'd prepare patches to
> drop it from the UpdateStore altogether (since we do not
> seem to use it)

Thanks!

[pbs-devel] applied: [PATCH proxmox-backup 1/2] ui: NavigationTree: do not modify list while iterating

[Dietmar Maurer]

applied both patches