public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup v3] restrict consent-banner text length
Date: Tue, 8 Apr 2025 15:08:18 +0200	[thread overview]
Message-ID: <48163dee-6a79-4d26-83cd-26de26b0eca3@proxmox.com> (raw)
In-Reply-To: <6s7fazsazrlsa4m6mvigbhqes3xq7vqj3qbxkddozyrhhdztkm@cqeqb623pouy>

Am 08.04.25 um 15:01 schrieb Gabriel Goller:
> On 08.04.2025 14:58, Gabriel Goller wrote:
>> On 08.04.2025 13:08, Thomas Lamprecht wrote:
>>> Am 10.12.24 um 16:53 schrieb Gabriel Goller:
>>>> Add a maxLength in of 63*1024 in the frontend. We allow a max body
>>>> size of 64*1204 in the api and to allow some other properties to
>>>> coexist, reserve 1024 characters. In the backend we set the limit to
>>>> 128000 (128kB), which is the same as in pve.
>>>
>>> I reduced it in PVE a bit again; might also make sense to increase the
>>> max POST size to 512 KiB just like in PVE, the rust based HTTP server
>>> should handle these sizes without a sweat if the perl one can do that.
>>
>> I'll send a patch soon with a limit of 64kB on both frontend and api.
>> The increasing of the max body size is IMO better in a future patch as
>> that will need some testing.
> 
> *63kB oops, we still need to let some room for other properties.

That's why I'd increase the post size limit, it's a trivial logical
check, not really sure what's much to test there?


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


      reply	other threads:[~2025-04-08 13:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-10 15:53 Gabriel Goller
2025-04-08 11:08 ` Thomas Lamprecht
2025-04-08 12:58   ` Gabriel Goller
2025-04-08 13:01     ` Gabriel Goller
2025-04-08 13:08       ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48163dee-6a79-4d26-83cd-26de26b0eca3@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal