From: Dietmar Maurer <dietmar@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup 2/2] api2: tape: restore: add warning for list restore
Date: Tue, 13 Jul 2021 12:05:00 +0200 [thread overview]
Message-ID: <46ebb399-24a4-0b1a-ab98-2bba9c3efc39@proxmox.com> (raw)
In-Reply-To: <20210713091125.2064985-2-d.csapak@proxmox.com>
applied
On 7/13/21 11:11 AM, Dominik Csapak wrote:
> if an error occurs, the snapshot dirs will already be created, and we
> do not clean them up (some might already be finished).
>
> Warn the user that they are not cleaned up.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> src/api2/tape/restore.rs | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/src/api2/tape/restore.rs b/src/api2/tape/restore.rs
> index 68033c4a..f959a856 100644
> --- a/src/api2/tape/restore.rs
> +++ b/src/api2/tape/restore.rs
> @@ -647,6 +647,10 @@ fn restore_list_worker(
> Ok(())
> });
>
> + if res.is_err() {
> + task_warn!(worker, "Error during restore, partially restored snapshots will NOT be cleaned up");
> + }
> +
> match std::fs::remove_dir_all(&base_path) {
> Ok(()) => {}
> Err(err) => task_warn!(worker, "error cleaning up: {}", err),
next prev parent reply other threads:[~2021-07-13 10:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 9:11 [pbs-devel] [PATCH proxmox-backup 1/2] chunk_store/insert_chunk: add more information to file errors Dominik Csapak
2021-07-13 9:11 ` [pbs-devel] [PATCH proxmox-backup 2/2] api2: tape: restore: add warning for list restore Dominik Csapak
2021-07-13 10:05 ` Dietmar Maurer [this message]
2021-07-13 9:56 ` [pbs-devel] applied: [PATCH proxmox-backup 1/2] chunk_store/insert_chunk: add more information to file errors Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46ebb399-24a4-0b1a-ab98-2bba9c3efc39@proxmox.com \
--to=dietmar@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox