From: Christian Ebner <c.ebner@proxmox.com>
To: Dietmar Maurer <dietmar@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [RFC proxmox-backup] fix #5710: api: backup: stat known chunks during backup
Date: Tue, 17 Sep 2024 13:40:57 +0200 [thread overview]
Message-ID: <4611dc8b-ed62-47bd-a4b5-11e76459b299@proxmox.com> (raw)
In-Reply-To: <27cfdbaa-eb6d-4585-a339-5640cf2ac323@proxmox.com>
On 9/17/24 09:19, Christian Ebner wrote:
> On 9/13/24 17:23, Dietmar Maurer wrote:
>>
>>
>> Is it possible to only stat actually reused chunks at the end?
>
> Yes, as is all the chunks, even not reused but indexed by the previous
> backup snapshot are stat'ed.
>
> I can add an additional flag to the hashmap's value storing known chunks
> to differentiate and only stat these.
>
> Will send a new version of the patch.
Unfortunately, the accounting of known chunks for fixed indices when
using the incremental mode turns out to be harder than expected.
For this case, the index is initially copied over from the previous
snapshot and chunk digests inserted into the known chunks hashmap.
On client side, only changed chunks are uploaded via the backup api, and
inserted in the fixed index on the corresponding index position. The
information which previously indexed chunk it replaced is however lacking.
Because of this, I currently tend to rather not modify the current
behavior and stat all of the known chunks.
Any thoughts on this? Is there a better approach I currently am failing
to see?
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-09-17 11:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 13:59 Christian Ebner
2024-09-13 15:23 ` Dietmar Maurer
2024-09-17 7:19 ` Christian Ebner
2024-09-17 11:40 ` Christian Ebner [this message]
2024-09-18 8:54 ` Dietmar Maurer
2024-09-16 10:17 ` Gabriel Goller
2024-09-17 7:23 ` Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4611dc8b-ed62-47bd-a4b5-11e76459b299@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=dietmar@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox