public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: Hannes Laimer <h.laimer@proxmox.com>, pbs-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox-backup] datastore: don't skip empty namespaces on s3 refresh
Date: Wed, 4 Mar 2026 15:19:55 +0100	[thread overview]
Message-ID: <453971bc-1536-49ab-a5e3-74f2ed2729f7@proxmox.com> (raw)
In-Reply-To: <20260304103938.42167-1-h.laimer@proxmox.com>

Thanks for fixing this issue!

On 3/4/26 11:39 AM, Hannes Laimer wrote:
> Without this empty namespaces present on s3 won't be visible locally.
> 
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>

Tested by creating an (nested as well as root) empty namespace for a 
datastore backed by s3 and performing an s3 refresh. With the patch 
applied the namespace folder structure is created with ownership and 
permissions as expected.

Non empty namespaces did not suffer the issue, but still work as 
expected as well.

Reviewed-by: Christian Ebner <c.ebner@proxmox.com>
Tested-by: Christian Ebner <c.ebner@proxmox.com>




      reply	other threads:[~2026-03-04 14:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-04 10:39 Hannes Laimer
2026-03-04 14:19 ` Christian Ebner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=453971bc-1536-49ab-a5e3-74f2ed2729f7@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=h.laimer@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal