Re: [pbs-devel] [PATCH proxmox-backup] pbs-tape/docs/api: fix miscellaneous typos

[Dylan Whyte <d.whyte@proxmox.com>]

Hi,

Thanks for the patch. Just some small suggestions, while you're at it ;)


Reviewed-by: Dylan Whyte <d.whyte@proxmox.com>

Best regards,

Dylan

On 3/9/22 14:53, Stefan Sterz wrote:
> Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
> ---
>   docs/epilog.rst             | 2 +-
>   docs/terminology.rst        | 2 +-
>   pbs-tape/src/bin/pmt.rs     | 2 +-
>   src/api2/admin/datastore.rs | 2 +-
>   4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/docs/epilog.rst b/docs/epilog.rst
> index 54e21a03..ed6a8800 100644
> --- a/docs/epilog.rst
> +++ b/docs/epilog.rst
> @@ -35,7 +35,7 @@
>   .. _ZFS: https://en.wikipedia.org/wiki/ZFS
>   .. _Proxmox VE: https://pve.proxmox.com
>   
> -.. _RFC3399: https://tools.ietf.org/html/rfc3339
> +.. _RFC3339: https://tools.ietf.org/html/rfc3339
>   .. _UTC: https://en.wikipedia.org/wiki/Coordinated_Universal_Time
>   .. _ISO Week date: https://en.wikipedia.org/wiki/ISO_week_date
>   
> diff --git a/docs/terminology.rst b/docs/terminology.rst
> index dcce117b..c5551818 100644
> --- a/docs/terminology.rst
> +++ b/docs/terminology.rst
> @@ -116,7 +116,7 @@ uniquely identifies a specific backup within a datastore.
>       vm/104/2019-10-09T08:01:06Z
>       host/elsa/2019-11-08T09:48:14Z
>   
> -As you can see, the time format is RFC3399_ with Coordinated
> +As you can see, the time format is RFC3339_ with Coordinated
>   Universal Time (UTC_, identified by the trailing *Z*).
>   
>   
> diff --git a/pbs-tape/src/bin/pmt.rs b/pbs-tape/src/bin/pmt.rs
> index 8f61c322..e7080bd8 100644
> --- a/pbs-tape/src/bin/pmt.rs
> +++ b/pbs-tape/src/bin/pmt.rs
> @@ -1,7 +1,7 @@
>   /// Control magnetic tape drive operation
>   ///
>   /// This is a Rust implementation, using the Proxmox userspace tape
> -/// driver. This is meant as replacement fot the 'mt' command line
> +/// driver. This is meant as replacement for the 'mt' command line
s/as replacement/as a replacement/
>   /// tool.
>   ///
>   /// Features:
> diff --git a/src/api2/admin/datastore.rs b/src/api2/admin/datastore.rs
> index 263ea96f..c0a87c1a 100644
> --- a/src/api2/admin/datastore.rs
> +++ b/src/api2/admin/datastore.rs
> @@ -273,7 +273,7 @@ pub fn delete_group(
>       check_priv_or_backup_owner(&datastore, &group, &auth_id, PRIV_DATASTORE_MODIFY)?;
>   
>       if !datastore.remove_backup_group(&group)? {
> -        bail!("did not delete whole group because of protected snapthots");
> +        bail!("did not delete whole group because of protected snapshots");

I would reword to: "group only partially deleted due to protected snapshots"

>       }
>   
>       Ok(Value::Null)