From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Gabriel Goller <g.goller@proxmox.com>,
Lukas Wagner <l.wagner@proxmox.com>
Subject: Re: [pbs-devel] [PATCH v2 proxmox{-backup, } 0/3] Add boot_mode, improve kernel version
Date: Mon, 27 Nov 2023 10:13:30 +0100 [thread overview]
Message-ID: <42798cdd-5ab1-43ef-8661-c017ff410f8a@proxmox.com> (raw)
In-Reply-To: <329f626f-e78d-413f-9220-deed3621f7a7@proxmox.com>
On 27.11.23 09:56, Gabriel Goller wrote:
> On a second note, I don't like this.
> We don't support enum variants (fields) with the `api` macro, so I would
> have to create
> a struct containing `mode` and `secureboot`. That again implies that
> bios + secureboot is
> possible, which is not.
No that really does not imply that, especially if you use an option fro
secureboot.
> But I get your argument about consistency between products, so if we'd
> go that
> way, I'd send another patch with the requested changes...
>
Just to be fully sure: we will NOT take anything in here that isn't 1:1
compatible with what PVE produces on the line (i.e., serialized) what
it looks internal I do not bother (that much).
prev parent reply other threads:[~2023-11-27 9:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-24 12:02 Gabriel Goller
2023-11-24 12:02 ` [pbs-devel] [PATCH v2 proxmox 1/3] sys: add function to get boot_mode Gabriel Goller
2023-11-24 14:19 ` Lukas Wagner
2023-11-24 12:02 ` [pbs-devel] [PATCH v2 proxmox-backup 2/3] node: status: added bootmode Gabriel Goller
2023-11-24 14:20 ` Lukas Wagner
2023-11-27 8:26 ` Gabriel Goller
2023-11-27 8:32 ` Lukas Wagner
2023-11-24 12:02 ` [pbs-devel] [PATCH v2 proxmox-backup 3/3] node: status: declutter kernel-version Gabriel Goller
2023-11-24 14:19 ` Lukas Wagner
2023-11-27 8:35 ` Gabriel Goller
2023-11-24 14:18 ` [pbs-devel] [PATCH v2 proxmox{-backup, } 0/3] Add boot_mode, improve kernel version Lukas Wagner
2023-11-24 14:45 ` Thomas Lamprecht
2023-11-27 8:41 ` Gabriel Goller
2023-11-27 8:56 ` Gabriel Goller
2023-11-27 9:13 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42798cdd-5ab1-43ef-8661-c017ff410f8a@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox