Re: [PATCH proxmox-backup v8 11/13] ui: add move group action

[Hannes Laimer <h.laimer@proxmox.com>]

On 2026-04-23 15:34, Michael Köppl wrote:
> On Wed Apr 22, 2026 at 3:39 PM CEST, Hannes Laimer wrote:
> 
> [snip]
> 
>> +    items: {
>> +        xtype: 'inputpanel',
>> +        onGetValues: function (values) {
>> +            let win = this.up('window');
>> +            let result = {
>> +                'backup-type': win.backupType,
>> +                'backup-id': win.backupId,
>> +                'target-ns': values['target-ns'] || '',
>> +            };
>> +            if (win.namespace && win.namespace !== '') {
>> +                result.ns = win.namespace;
>> +            }
>> +            if (values['merge-group'] !== undefined) {
>> +                result['merge-group'] = values['merge-group'];
>> +            }
> 
> when I uncheck the "Merge Group" checkbox, the `merge-group` param is
> not set in the request. since the default value in the backend is
> `true`, merging is still attempted.
> 

right, good catch! should just use `delete_if_default(.., true)`

>> +            return result;
>> +        },
>> +        items: [
>> +            {
>> +                xtype: 'displayfield',
>> +                fieldLabel: gettext('Group'),
>> +                cbind: {
>> +                    value: '{group}',
>> +                },
> 
> [snip]