From: Matthias Heiserer <m.heiserer@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>, pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH proxmox-backup 2/2] prune-simulator: allow setting a time on which prune happens
Date: Mon, 19 Sep 2022 12:24:19 +0200 [thread overview]
Message-ID: <4195287a-9de0-4199-182f-9afd3a721307@proxmox.com> (raw)
In-Reply-To: <fffd64d5-3717-dfbe-64b1-1c96f1b3cdef@proxmox.com>
On 16.09.2022 12:08, Fiona Ebner wrote:
> Same nit for the commit title.
>
> Am 14.09.22 um 12:50 schrieb Matthias Heiserer:
>> @@ -726,6 +730,15 @@ Ext.onReady(function() {
>> padding: '0 0 0 10',
>> value: new Date(),
>> },
>> + {
>> + xtype: 'timefield',
>> + name: 'currentTime',
>> + reference: 'currentTime',
>> + fieldLabel: 'Time of prune',
>
> I don't really like using "Time of prune" here, because the setting also
> affects the schedule and doesn't feel in line with "Today". How about
> "Today's time" or simply "Time"? Or we could use "Current date" and
> "Current time".
I think just "Time" works best. I'll also rename the date field to
"Date" to keep it consistent (and because it makes more sense; from the
view of the user, its not the current date, but the date which is used
for the simulation).
>
> There's AM/PM times in the drop-down suggestions here, which clashes
> with the 24 hour format used in the rest of the simulator. Let's try to
> keep it consistent.
>
Of course, good catch
>> + allowBlank: false,
>> + padding: '0 0 0 10',
>> + value: new Date(),
>> + },
>> ],
>> },
>> ],
next prev parent reply other threads:[~2022-09-19 10:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 10:50 [pbs-devel] [PATCH proxmox-backup 1/2] prune-simulator: allow setting a date " Matthias Heiserer
2022-09-14 10:50 ` [pbs-devel] [PATCH proxmox-backup 2/2] prune-simulator: allow setting a time " Matthias Heiserer
2022-09-16 10:08 ` Fiona Ebner
2022-09-19 10:24 ` Matthias Heiserer [this message]
2022-09-16 10:08 ` [pbs-devel] [PATCH proxmox-backup 1/2] prune-simulator: allow setting a date " Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4195287a-9de0-4199-182f-9afd3a721307@proxmox.com \
--to=m.heiserer@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox