From: Lukas Wagner <l.wagner@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Christian Ebner <c.ebner@proxmox.com>,
Wolfgang Bumiller <w.bumiller@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-rrd] cache: skip non-utf8 lines in rrd journal
Date: Fri, 28 Jun 2024 14:25:18 +0200 [thread overview]
Message-ID: <414947c1-2a62-418f-a97c-c550368c490f@proxmox.com> (raw)
In-Reply-To: <750157630.1179.1719577219520@webmail.proxmox.com>
On 2024-06-28 14:20, Christian Ebner wrote:
>> On 28.06.2024 14:09 CEST Wolfgang Bumiller <w.bumiller@proxmox.com> wrote:
>> Do we even have anything non-ASCII in that file?
>> I'd think the file got corrupted some other way.
>> So would we really want to apply it? Perhaps just let the admin
>> clear/remove it?
>
> No, the file should per se be valid UTF-8, even ASCII only.
> I already replied to the user to clean up the file to solve the issue, fine by me if this is discarded.
>
The journal is applied on daemon startup and every 30 mins - so it should be fine
to just discard it, one loses only up to 30mins of metric data - which doesn't
sound so bad for a rare data corruption like this.
--
- Lukas
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2024-06-28 12:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-24 14:24 Christian Ebner
2024-06-24 15:53 ` Dietmar Maurer
2024-06-24 17:30 ` Christian Ebner
2024-06-28 12:09 ` Wolfgang Bumiller
2024-06-28 12:20 ` Christian Ebner
2024-06-28 12:25 ` Lukas Wagner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=414947c1-2a62-418f-a97c-c550368c490f@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox