public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH proxmox-backup 3/4] api: verify: add worker-threads to update endpoint
Date: Thu, 6 Nov 2025 10:13:28 +0100	[thread overview]
Message-ID: <410d0f1d-1e35-4828-8e9a-8cd722f3cb0e@proxmox.com> (raw)
In-Reply-To: <20251105155129.517430-5-n.frey@proxmox.com>

Again a short commit message would be nice, e.g.

Allows to add, update or delete the worker-thread property in the verify 
job config via the API. This will control the number of workers to read 
(and verify?) chunks in the verification job.

On 11/5/25 4:51 PM, Nicolas Frey wrote:
> Signed-off-by: Nicolas Frey <n.frey@proxmox.com>
> ---
>   src/api2/config/verify.rs | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/src/api2/config/verify.rs b/src/api2/config/verify.rs
> index e71e0c2e..2847c984 100644
> --- a/src/api2/config/verify.rs
> +++ b/src/api2/config/verify.rs
> @@ -149,6 +149,8 @@ pub enum DeletableProperty {
>       Ns,
>       /// Delete max-depth property, defaulting to full recursion again
>       MaxDepth,
> +    /// Delete worker-threads property
> +    WorkerThreads,
>   }
>   
>   #[api(
> @@ -229,6 +231,9 @@ pub fn update_verification_job(
>                   DeletableProperty::MaxDepth => {
>                       data.max_depth = None;
>                   }
> +                DeletableProperty::WorkerThreads => {
> +                    data.worker_threads = None;
> +                }
>               }
>           }
>       }
> @@ -266,6 +271,9 @@ pub fn update_verification_job(
>               data.max_depth = Some(max_depth);
>           }
>       }
> +    if update.worker_threads.is_some() {
> +        data.worker_threads = update.worker_threads;
> +    }
>   
>       // check new store and NS
>       user_info.check_privs(&auth_id, &data.acl_path(), PRIV_DATASTORE_VERIFY, true)?;



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


  reply	other threads:[~2025-11-06  9:13 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-05 15:51 [pbs-devel] [PATCH proxmox{, -backup} 0/5] parallelize chunk reads in verification Nicolas Frey
2025-11-05 15:51 ` [pbs-devel] [PATCH proxmox 1/1] pbs-api-types: jobs: verify: add worker-threads to VerificationJobConfig Nicolas Frey
2025-11-06  8:14   ` Christian Ebner
2025-11-05 15:51 ` [pbs-devel] [PATCH proxmox-backup 1/4] api: verify: move chunk loading into parallel handler Nicolas Frey
2025-11-06  8:54   ` Christian Ebner
2025-11-06  9:04     ` Nicolas Frey
2025-11-06  9:26       ` Christian Ebner
2025-11-05 15:51 ` [pbs-devel] [PATCH proxmox-backup 2/4] api: verify: use worker-threads to determine the number of threads to use Nicolas Frey
2025-11-06  9:09   ` Christian Ebner
2025-11-06  9:23     ` Nicolas Frey
2025-11-06  9:32       ` Christian Ebner
2025-11-06 11:22         ` Nicolas Frey
2025-11-06 11:57           ` Christian Ebner
2025-11-05 15:51 ` [pbs-devel] [PATCH proxmox-backup 3/4] api: verify: add worker-threads to update endpoint Nicolas Frey
2025-11-06  9:13   ` Christian Ebner [this message]
2025-11-05 15:51 ` [pbs-devel] [PATCH proxmox-backup 4/4] ui: verify: add option to set number of threads for job Nicolas Frey
2025-11-06  9:22   ` Christian Ebner
2025-11-06  9:25     ` Nicolas Frey
2025-11-06  8:02 ` [pbs-devel] [PATCH proxmox{, -backup} 0/5] parallelize chunk reads in verification Christian Ebner
2025-11-06 16:15 ` [pbs-devel] superseded: " Nicolas Frey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=410d0f1d-1e35-4828-8e9a-8cd722f3cb0e@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal