public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>, Fiona Ebner <f.ebner@proxmox.com>
Subject: [pbs-devel] applied: [RFC proxmox-backup] ui: sync job edit: fix showing value for target store upon edit of local sync job
Date: Tue, 28 Nov 2023 18:52:46 +0100	[thread overview]
Message-ID: <409822f0-528c-492e-b458-9712cab94a72@proxmox.com> (raw)
In-Reply-To: <20231128160415.81314-1-f.ebner@proxmox.com>

Am 28/11/2023 um 17:04 schrieb Fiona Ebner:
> when editing a local sync job, the field would be empty because of
> this and not be set to the previously configured remote-store.
> 
> The binding is already used for the local datastore, not sure why it
> should even be applied to the target where it might not even be valid.
> 
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> 
> Not familiar enough with the code, so sending as RFC.
> 
>  www/window/SyncJobEdit.js | 3 ---
>  1 file changed, 3 deletions(-)
> 
>

seems reasonable enough: applied, thanks!




  reply	other threads:[~2023-11-28 17:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-28 16:04 [pbs-devel] " Fiona Ebner
2023-11-28 17:52 ` Thomas Lamprecht [this message]
2023-11-29  6:54 ` Hannes Laimer
2023-11-29  7:42   ` Fiona Ebner
2023-11-29  8:02     ` Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=409822f0-528c-492e-b458-9712cab94a72@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal