public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pbs-devel] [PATCH backup] fix #3336: cleanup when deleting last snapshot
@ 2025-03-06 12:08 Maximiliano Sandoval
  2025-03-07 10:37 ` Shannon Sterz
  0 siblings, 1 reply; 10+ messages in thread
From: Maximiliano Sandoval @ 2025-03-06 12:08 UTC (permalink / raw)
  To: pbs-devel

When the last snapshot from a group is deleted we clear the entire
group, this in turn cleans the owner for the group.

Without this change, the user is unable to change the owner of the group
after the last snapshot has been deleted. This would prevent a new
backups to the same group from a different owner.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 src/api2/admin/datastore.rs | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/src/api2/admin/datastore.rs b/src/api2/admin/datastore.rs
index dbb7ae47..305673f1 100644
--- a/src/api2/admin/datastore.rs
+++ b/src/api2/admin/datastore.rs
@@ -423,10 +423,20 @@ pub async fn delete_snapshot(
             &backup_dir.group,
         )?;
 
-        let snapshot = datastore.backup_dir(ns, backup_dir)?;
+        let snapshot = datastore.backup_dir(ns.clone(), backup_dir)?;
 
         snapshot.destroy(false)?;
 
+        let group = BackupGroup::from(snapshot);
+        if group.list_backups().is_ok_and(|backups| backups.is_empty()) {
+            if let Err(err) = datastore.remove_backup_group(&ns, group.as_ref()) {
+                log::error!(
+                    "error while cleaning group {path:?} - {err}",
+                    path = group.full_group_path()
+                );
+            }
+        }
+
         Ok(Value::Null)
     })
     .await?
-- 
2.39.5



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2025-03-11 10:41 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-03-06 12:08 [pbs-devel] [PATCH backup] fix #3336: cleanup when deleting last snapshot Maximiliano Sandoval
2025-03-07 10:37 ` Shannon Sterz
2025-03-07 15:33   ` Wolfgang Bumiller
2025-03-07 15:53     ` Shannon Sterz
2025-03-10 10:53       ` Wolfgang Bumiller
2025-03-10 15:19         ` Fabian Grünbichler
2025-03-10 15:22           ` Shannon Sterz
2025-03-11  9:21             ` Thomas Lamprecht
2025-03-11  9:52               ` Shannon Sterz
2025-03-11 10:40                 ` Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal