public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: Dietmar Maurer <dietmar@proxmox.com>,
	Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup v2 0/7] improve catalog handling
Date: Mon, 26 Jul 2021 10:37:30 +0200	[thread overview]
Message-ID: <3f349341-d27f-bcd8-b578-fd2631b8b88a@proxmox.com> (raw)
In-Reply-To: <704281229.1167.1627287980047@webmail.proxmox.com>



On 7/26/21 10:26 AM, Dietmar Maurer wrote:
> 
>> On 07/22/2021 3:40 PM Dominik Csapak <d.csapak@proxmox.com> wrote:
>>   
>> this series combines my previous catalog related patch-series[0][1][2]
>>
>> changes the catalog interface to be more concise, optimizes catalog
>> commit calls during restore, and implements a fast catalog for the
>> gui which only contains the snapshot lists
>>
>> changes from v1:
>> * only write snapshot list in new 'finish' method of the catalog
>> * add 'finish' also to pool writer
>> * replace pending offset counter with reducing the chunk_archive
>>    interface of the catalog
> 
> Now, during tape backup, users do not see any progress on the GUI. This
> can be particularly confusing on long running tape backups.
> 
> A simpler approach would be to only generate cache files for "finished" tapes (content
> will never change), while using the original catalog for tapes still writable. This should
> be much easier to implement?
> 

yes it would be simpler, but this does not completely solve the issue of
slow reads on large slow catalogs? (the last tape of the media-set can
still be so big that the reads take too long?)

also, the 'progress' they do not see is only in the 'content' view.
the task log of the running tape backup still shows the normal progress.

what about my suggestion to indicate a running backup in the content 
view instead ? so the user knows this is still running.

also what if the tape is damaged later in the backup? then the user
saw that some things are backed up, but in reality the tape
is broken and nothing is properly backed up?

also the progress in the content view was incomplete anyway
since we only updated that once every 128GiB (that can be
many snapshots) or at the end of the tape/backup

so if we do not want to update the cache only at the end of the 
backup/tape, i'd rather suggest to regenerate the cache on
each pool_writer commit, so we can profit from it even on
non-finished tapes




  reply	other threads:[~2021-07-26  8:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-26  8:26 Dietmar Maurer
2021-07-26  8:37 ` Dominik Csapak [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-07-26  8:43 Dietmar Maurer
2021-07-26  8:54 ` Dominik Csapak
2021-07-22 13:40 Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3f349341-d27f-bcd8-b578-fd2631b8b88a@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=dietmar@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal