[pbs-devel] [PATCH] api: sync: list `all` instead of only `pull` synch jobs by default

[pbs-devel] [PATCH] api: sync: list `all` instead of only `pull` synch jobs by default

[Hannes Laimer]

There is no reason to still default to only listing pulling jobs.

Reported-by: https://forum.proxmox.com/threads/pbs-api-aufruf.175211/
Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
 src/api2/admin/sync.rs | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/api2/admin/sync.rs b/src/api2/admin/sync.rs
index 6722ebea..c21a6909 100644
--- a/src/api2/admin/sync.rs
+++ b/src/api2/admin/sync.rs
@@ -23,18 +23,17 @@ use crate::{
     server::sync::do_sync_job,
 };
 
-// FIXME: 4.x make 'all' the default
 #[api()]
 #[derive(Copy, Clone, Debug, Default, Eq, PartialEq, Serialize, Deserialize)]
 #[serde(rename_all = "kebab-case")]
 /// The direction of the listed sync jobs: push, pull or all.
 pub enum ListSyncDirection {
     /// All directions
+    #[default]
     All,
     /// Sync direction push
     Push,
     /// Sync direction pull
-    #[default]
     Pull,
 }
 
-- 
2.47.3



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

Re: [pbs-devel] [PATCH] api: sync: list `all` instead of only `pull` synch jobs by default

[Christian Ebner]

On 11/4/25 8:34 AM, Hannes Laimer wrote:
> There is no reason to still default to only listing pulling jobs.

Well, this was overlooked for PBS 4.0, but I'm afraid the change needs 
to be postponed to PBS version 5.0, as this is a breaking API change.

> 
> Reported-by: https://forum.proxmox.com/threads/pbs-api-aufruf.175211/
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
>   src/api2/admin/sync.rs | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/src/api2/admin/sync.rs b/src/api2/admin/sync.rs
> index 6722ebea..c21a6909 100644
> --- a/src/api2/admin/sync.rs
> +++ b/src/api2/admin/sync.rs
> @@ -23,18 +23,17 @@ use crate::{
>       server::sync::do_sync_job,
>   };
>   
> -// FIXME: 4.x make 'all' the default
>   #[api()]
>   #[derive(Copy, Clone, Debug, Default, Eq, PartialEq, Serialize, Deserialize)]
>   #[serde(rename_all = "kebab-case")]
>   /// The direction of the listed sync jobs: push, pull or all.
>   pub enum ListSyncDirection {
>       /// All directions
> +    #[default]
>       All,
>       /// Sync direction push
>       Push,
>       /// Sync direction pull
> -    #[default]
>       Pull,
>   }
>   


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel