From: Christian Ebner <c.ebner@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Hannes Laimer <h.laimer@proxmox.com>
Subject: Re: [pbs-devel] [PATCH] api: sync: list `all` instead of only `pull` synch jobs by default
Date: Tue, 4 Nov 2025 09:58:56 +0100 [thread overview]
Message-ID: <3f25e78c-d445-4567-a723-34935a7b0cb8@proxmox.com> (raw)
In-Reply-To: <20251104073403.14933-1-h.laimer@proxmox.com>
On 11/4/25 8:34 AM, Hannes Laimer wrote:
> There is no reason to still default to only listing pulling jobs.
Well, this was overlooked for PBS 4.0, but I'm afraid the change needs
to be postponed to PBS version 5.0, as this is a breaking API change.
>
> Reported-by: https://forum.proxmox.com/threads/pbs-api-aufruf.175211/
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
> src/api2/admin/sync.rs | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/src/api2/admin/sync.rs b/src/api2/admin/sync.rs
> index 6722ebea..c21a6909 100644
> --- a/src/api2/admin/sync.rs
> +++ b/src/api2/admin/sync.rs
> @@ -23,18 +23,17 @@ use crate::{
> server::sync::do_sync_job,
> };
>
> -// FIXME: 4.x make 'all' the default
> #[api()]
> #[derive(Copy, Clone, Debug, Default, Eq, PartialEq, Serialize, Deserialize)]
> #[serde(rename_all = "kebab-case")]
> /// The direction of the listed sync jobs: push, pull or all.
> pub enum ListSyncDirection {
> /// All directions
> + #[default]
> All,
> /// Sync direction push
> Push,
> /// Sync direction pull
> - #[default]
> Pull,
> }
>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2025-11-04 8:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-04 7:34 Hannes Laimer
2025-11-04 8:58 ` Christian Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f25e78c-d445-4567-a723-34935a7b0cb8@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox