Re: [pbs-devel] [PATCH widget-toolkit] auth: ldap: openid: use proxmoxtextfield for comment

[Lukas Wagner <l.wagner@proxmox.com>]

Ping

On 7/18/23 13:57, Lukas Wagner wrote:
> The regular `textfield` does not support the `deleteEmpty`
> setting. Thus, if no comment was entered the configuration
> would still end up with an empty `comment` key:
> 
> ldap: foo
>      server ....
>      bind-dn ...
>      comment
> 
> Fixed by switching over to `proxmoxtextfield`, which properly
> deletes empty keys.
> 
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
>   src/window/AuthEditLDAP.js   | 2 +-
>   src/window/AuthEditOpenId.js | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/window/AuthEditLDAP.js b/src/window/AuthEditLDAP.js
> index 6aafb98..eb9700a 100644
> --- a/src/window/AuthEditLDAP.js
> +++ b/src/window/AuthEditLDAP.js
> @@ -187,7 +187,7 @@ Ext.define('Proxmox.panel.LDAPInputPanel', {
>   
>       columnB: [
>   	{
> -	    xtype: 'textfield',
> +	    xtype: 'proxmoxtextfield',
>   	    name: 'comment',
>   	    fieldLabel: gettext('Comment'),
>   	    cbind: {
> diff --git a/src/window/AuthEditOpenId.js b/src/window/AuthEditOpenId.js
> index 52a7521..ca84958 100644
> --- a/src/window/AuthEditOpenId.js
> +++ b/src/window/AuthEditOpenId.js
> @@ -112,7 +112,7 @@ Ext.define('Proxmox.panel.OpenIDInputPanel', {
>   
>       columnB: [
>   	{
> -	    xtype: 'textfield',
> +	    xtype: 'proxmoxtextfield',
>   	    name: 'comment',
>   	    fieldLabel: gettext('Comment'),
>   	    cbind: {

-- 
- Lukas