Re: [pbs-devel] applied-series: [PATCH proxmox-backup 0/3] fix #5285: log global statistics for sync job

[Christian Ebner <c.ebner@proxmox.com>]

On 3/7/24 14:59, Thomas Lamprecht wrote:
> 
> Albeit for such things it would be nice to add an example (excerpt) of the
> new message/format in the commit message – I amended the respective commit
> with that.

Thanks, will keep that in mind for next time.

> 
> I also found a glitch for the case where no new data was pulled, as then
> one got the following log entry:
> 
>> Summary: sync job pulled 0 B in 0 chunks (average rate: NaN B/s) >
> I made a follow-up commit that makes the API log a different messages
> in that case.

Had that case as well, but was thinking of taking a look at how to 
better handle such a `NaN` case in the `human_byte` crate. But I agree, 
the output is cleaner with your followup.

> 
> Something that might be still relevant is mentioning the amount of
> deleted (vanished) backups/groups in the summary.

Okay, will have a look at integrating that as well.

Thanks for your comments and to Max for review and testing!