From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Hannes Laimer <h.laimer@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 1/5] pbs-api-types: add maintenance type and msg to ds config
Date: Fri, 1 Oct 2021 10:23:08 +0200 [thread overview]
Message-ID: <3d462fcd-90c8-ea79-fbcf-66bcec1df286@proxmox.com> (raw)
In-Reply-To: <20210928100548.4873-2-h.laimer@proxmox.com>
On 9/28/21 12:05, Hannes Laimer wrote:
> ---
> pbs-api-types/src/datastore.rs | 33 +++++++++++++++++++++++++++++++++
> 1 file changed, 33 insertions(+)
>
> diff --git a/pbs-api-types/src/datastore.rs b/pbs-api-types/src/datastore.rs
> index 75f82ea4..80ae77f2 100644
> --- a/pbs-api-types/src/datastore.rs
> +++ b/pbs-api-types/src/datastore.rs
> @@ -165,6 +165,26 @@ pub struct PruneOptions {
> pub keep_yearly: Option<u64>,
> }
>
> +#[api()]
> +#[derive(PartialOrd, Debug, Copy, Clone, PartialEq, Serialize, Deserialize)]
> +#[serde(rename_all = "lowercase")]
> +/// Different maintenance types.
> +pub enum MaintenanceType {
> + /// Only reading operations are allowed.
> + ReadOnly,
> + /// Neither reading nor writing is allowed on the datastore.
> + Offline,
> +}
> +
> +impl std::fmt::Display for MaintenanceType {
> + fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
> + match *self {
> + MaintenanceType::ReadOnly => write!(f, "read only"),
since that goes into the config and api (AFAICS), i'd not use spaces in
the value. we could use 'read-only' for example, but maybe check other
parts of the api/configs where we may have values similar to this
> + MaintenanceType::Offline => write!(f, "offline"),
> + }
> + }
> +}
> +
> #[api(
> properties: {
> name: {
> @@ -222,6 +242,15 @@ pub struct PruneOptions {
> optional: true,
> type: bool,
> },
> + "maintenance-type": {
> + optional: true,
> + type: MaintenanceType,
> + },
> + "maintenance-msg": {
> + description: "Text that will be shown as a description for the maintenance.",
> + optional: true,
> + type: String,
> + },
i think we could combine the message + type in the enum, we just have
to manually to the deserialization (look for example how we
do the media-location for tapes, there we can have a named 'vault'
which gets (de)serialized as/from "vault-NAME"
we could to the same here with "read-only-foo' and 'offline-foo'
this would make for a nicer api maybe? (any other opinions @thomas
@wolfgang @dietmar?)
also i think the way it is now, i could update the maintenance message
without setting a mode...
> }
> )]
> #[derive(Serialize,Deserialize,Updater)]
> @@ -259,6 +288,10 @@ pub struct DataStoreConfig {
> /// Send notification only for job errors
> #[serde(skip_serializing_if="Option::is_none")]
> pub notify: Option<String>,
> + #[serde(skip_serializing_if="Option::is_none")]
> + pub maintenance_type: Option<MaintenanceType>,
> + #[serde(skip_serializing_if="Option::is_none")]
> + pub maintenance_msg: Option<String>,
> }
>
> #[api(
>
next prev parent reply other threads:[~2021-10-01 8:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 10:05 [pbs-devel] [PATCH proxmox-backup 0/5] maintenance mode for datastore Hannes Laimer
2021-09-28 10:05 ` [pbs-devel] [PATCH proxmox-backup 1/5] pbs-api-types: add maintenance type and msg to ds config Hannes Laimer
2021-10-01 8:23 ` Dominik Csapak [this message]
2021-10-01 12:00 ` Wolfgang Bumiller
2021-09-28 10:05 ` [pbs-devel] [PATCH proxmox-backup 2/5] pbs-datastore: add check_maintenence function Hannes Laimer
2021-10-01 12:06 ` Wolfgang Bumiller
2021-09-28 10:05 ` [pbs-devel] [PATCH proxmox-backup 3/5] api2: make maintenance type and msg updatable/deletable Hannes Laimer
2021-09-28 10:05 ` [pbs-devel] [PATCH proxmox-backup 4/5] jobs/api2: add checks for maintenance Hannes Laimer
2021-10-01 8:28 ` Dominik Csapak
2021-09-28 10:05 ` [pbs-devel] [PATCH proxmox-backup 5/5] ui: add maintenance to datastore options Hannes Laimer
2021-10-01 8:36 ` Dominik Csapak
2021-10-01 8:18 ` [pbs-devel] [PATCH proxmox-backup 0/5] maintenance mode for datastore Dominik Csapak
2021-10-01 9:36 ` Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d462fcd-90c8-ea79-fbcf-66bcec1df286@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox